fix: add support for handling NewExpression in _tools/eslint/rules/line-closing-bracket-spacing

PR-URL: stdlib-js#4343
Reviewed-by: Athan Reines <[email protected]>

Author: headlessNode

lib/node_modules/@stdlib/_tools/eslint/rules/line-closing-bracket-spacing/lib/main.js

@@ -82,7 +82,7 @@ function main( context ) {
 		var args;
 
 		if (
-			node.type === 'CallExpression' &&
+			( node.type === 'CallExpression' || node.type === 'NewExpression' ) &&
 			node.arguments.length > 0
 		) {
 			args = node.arguments;
@@ -99,7 +99,10 @@ function main( context ) {
 				) {
 					report( node, prevToken, tokenAfter );
 				}
-			} else if ( lastElem.type === 'ArrayExpression' ) {
+			} else if (
+				lastElem.type === 'ArrayExpression' &&
+				lastElem.elements.length > 0
+			) {
 				elem = lastElem.elements[ lastElem.elements.length - 1 ];
 				if (
 					elem.type === 'ObjectExpression' &&
@@ -150,6 +153,7 @@ function main( context ) {
 	}
 	return {
 		'CallExpression': validate,
+		'NewExpression': validate,
 		'ArrayExpression': validate
 	};
 }

lib/node_modules/@stdlib/_tools/eslint/rules/line-closing-bracket-spacing/test/fixtures/invalid.js

@@ -18,7 +18,7 @@
 
 'use strict';
 
-var valid = [];
+var invalid = [];
 var test;
 
 test = {
@@ -39,7 +39,7 @@ test = {
 		'}];'
 	].join( '\n' )
 };
-valid.push( test );
+invalid.push( test );
 
 test = {
 	'code': [
@@ -77,7 +77,7 @@ test = {
 		']);'
 	].join( '\n' )
 };
-valid.push( test );
+invalid.push( test );
 
 test = {
 	'code': [
@@ -107,7 +107,7 @@ test = {
 		'}]);'
 	].join( '\n' )
 };
-valid.push( test);
+invalid.push( test );
 
 test = {
 	'code': [
@@ -137,7 +137,7 @@ test = {
 		'}]);'
 	].join( '\n' )
 };
-valid.push( test);
+invalid.push( test );
 
 test = {
 	'code': [
@@ -170,7 +170,7 @@ test = {
 		'}]);'
 	].join( '\n' )
 };
-valid.push( test);
+invalid.push( test );
 
 test = {
 	'code': [
@@ -202,7 +202,7 @@ test = {
 		'*/'
 	].join( '\n' )
 };
-valid.push( test );
+invalid.push( test );
 
 test = {
 	'code': [
@@ -222,9 +222,45 @@ test = {
 		'});'
 	].join( '\n' )
 };
-valid.push( test );
+invalid.push( test );
+
+test = {
+	'code': [
+		'  var v = new ndindex({',
+		'    \'kind\': \'linear\'',
+		'  } ); // some comment'
+	].join( '\n' ),
+	'errors': [{
+		'message': 'No spaces allowed between a closing parenthesis or bracket and a nested object or array expression at the beginning of a line',
+		'type': null
+	}],
+	'output': [
+		'  var v = new ndindex({',
+		'    \'kind\': \'linear\'',
+		'  }); // some comment'
+	].join( '\n' )
+};
+invalid.push( test );
+
+test = {
+	'code': [
+		'  var v = new ndindex({',
+		'    \'kind\': \'linear\'',
+		'  } );'
+	].join( '\n' ),
+	'errors': [{
+		'message': 'No spaces allowed between a closing parenthesis or bracket and a nested object or array expression at the beginning of a line',
+		'type': null
+	}],
+	'output': [
+		'  var v = new ndindex({',
+		'    \'kind\': \'linear\'',
+		'  });'
+	].join( '\n' )
+};
+invalid.push( test );
 
 
 // EXPORTS //
 
-module.exports = valid;
+module.exports = invalid;

lib/node_modules/@stdlib/_tools/eslint/rules/line-closing-bracket-spacing/test/fixtures/unvalidated.js

@@ -33,22 +33,22 @@ test = {
 		'var arrSum = sum( [ 1, 2, 3, 4 ] );'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
 
 test = {
 	'code': [
 		'  var log = require( \'@stdlib/console/log\' );',
 		'  log( {} );'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
 
 test = {
 	'code': [
 		'var arr = [ 1, 2, 3, 4, {} ];'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
 
 test = {
 	'code': [
@@ -60,7 +60,7 @@ test = {
 		'  );'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
 
 test = {
 	'code': [
@@ -73,7 +73,7 @@ test = {
 		'  );'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
 
 test = {
 	'code': [
@@ -87,7 +87,7 @@ test = {
 		'  );'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
 
 test = {
 	'code': [
@@ -98,7 +98,42 @@ test = {
 		'];'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
+
+test = {
+	'code': [
+		'  var x = array( [] );'
+	].join( '\n' )
+};
+valid.push( test );
+
+test = {
+	'code': [
+		'  var x = array( [ {} ] );'
+	].join( '\n' )
+};
+valid.push( test );
+
+test = {
+	'code': [
+		'  var x = new Float64Array( [ 1, 2, 3, 4 ] );'
+	].join( '\n' )
+};
+valid.push( test );
+
+test = {
+	'code': [
+		'  var x = new Float64Array(',
+		'    [',
+		'      1,',
+		'      2,',
+		'      3,',
+		'      4',
+		'    ]',
+		'  );'
+	].join( '\n' )
+};
+valid.push( test );
 
 
 // EXPORTS //

lib/node_modules/@stdlib/_tools/eslint/rules/line-closing-bracket-spacing/test/fixtures/valid.js

@@ -48,7 +48,7 @@ test = {
 		']);'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
 
 test = {
 	'code': [
@@ -63,7 +63,7 @@ test = {
 		'}]);'
 	].join( '\n' )
 };
-valid.push( test);
+valid.push( test );
 
 test = {
 	'code': [
@@ -91,6 +91,24 @@ test = {
 };
 valid.push( test );
 
+test = {
+	'code': [
+		'  var v = new ndindex({',
+		'    \'kind\': \'linear\'',
+		'  }); // some comment'
+	].join( '\n' )
+};
+valid.push( test );
+
+test = {
+	'code': [
+		'  var v = new ndindex({',
+		'    \'kind\': \'linear\'',
+		'  });'
+	].join( '\n' )
+};
+valid.push( test );
+
 
 // EXPORTS //