Skip to content

Commit 6a2b65b

Browse files
fix: bench errors
1 parent 366ef62 commit 6a2b65b

File tree

5 files changed

+29
-69
lines changed

5 files changed

+29
-69
lines changed

lib/node_modules/@stdlib/stats/base/dsmeanors/benchmark/benchmark.js

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,20 @@
2222

2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/base/uniform' );
25-
var bernoulli = require( '@stdlib/random/base/bernoulli' );
26-
var filledarrayBy = require( '@stdlib/array/filled-by' );
2725
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2826
var pow = require( '@stdlib/math/base/special/pow' );
2927
var pkg = require( './../package.json' ).name;
3028
var dsmeanors = require( './../lib/dsmeanors.js' );
3129

3230

33-
// FUNCTIONS //
31+
// VARIABLES //
3432

35-
/**
36-
* Returns a random value or `NaN`.
37-
*
38-
* @returns {number} random number or `NaN`
39-
*/
40-
function rand() {
41-
if ( bernoulli( 0.2 ) ) {
42-
return NaN;
43-
}
44-
return uniform( -10.0, 10.0 );
45-
}
33+
var options = {
34+
'dtype': 'float32'
35+
};
36+
37+
38+
// FUNCTIONS //
4639

4740
/**
4841
* Creates a benchmark function.
@@ -52,7 +45,7 @@ function rand() {
5245
* @returns {Function} benchmark function
5346
*/
5447
function createBenchmark( len ) {
55-
var x = filledarrayBy( len, 'float32', rand );
48+
var x = uniform( len, -10.0, 10.0, options );
5649
return benchmark;
5750

5851
function benchmark( b ) {

lib/node_modules/@stdlib/stats/base/dsmeanors/benchmark/benchmark.native.js

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var uniform = require( '@stdlib/random/base/uniform' );
26-
var bernoulli = require( '@stdlib/random/base/bernoulli' );
27-
var filledarrayBy = require( '@stdlib/array/filled-by' );
2826
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2927
var pow = require( '@stdlib/math/base/special/pow' );
3028
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -37,22 +35,13 @@ var dsmeanors = tryRequire( resolve( __dirname, './../lib/dsmeanors.native.js' )
3735
var opts = {
3836
'skip': ( dsmeanors instanceof Error )
3937
};
38+
var options = {
39+
'dtype': 'float32'
40+
};
4041

4142

4243
// FUNCTIONS //
4344

44-
/**
45-
* Returns a random value or `NaN`.
46-
*
47-
* @returns {number} random number or `NaN`
48-
*/
49-
function rand() {
50-
if ( bernoulli( 0.2 ) ) {
51-
return NaN;
52-
}
53-
return uniform( -10.0, 10.0 );
54-
}
55-
5645
/**
5746
* Creates a benchmark function.
5847
*
@@ -61,7 +50,7 @@ function rand() {
6150
* @returns {Function} benchmark function
6251
*/
6352
function createBenchmark( len ) {
64-
var x = filledarrayBy( len, 'float32', rand );
53+
var x = uniform( len, -10.0, 10.0, options );
6554
return benchmark;
6655

6756
function benchmark( b ) {

lib/node_modules/@stdlib/stats/base/dsmeanors/benchmark/benchmark.ndarray.js

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,20 @@
2222

2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/base/uniform' );
25-
var bernoulli = require( '@stdlib/random/base/bernoulli' );
26-
var filledarrayBy = require( '@stdlib/array/filled-by' );
2725
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2826
var pow = require( '@stdlib/math/base/special/pow' );
2927
var pkg = require( './../package.json' ).name;
3028
var dsmeanors = require( './../lib/ndarray.js' );
3129

3230

33-
// FUNCTIONS //
31+
// VARIABLES //
3432

35-
/**
36-
* Returns a random value or `NaN`.
37-
*
38-
* @returns {number} random number or `NaN`
39-
*/
40-
function rand() {
41-
if ( bernoulli( 0.2 ) ) {
42-
return NaN;
43-
}
44-
return uniform( -10.0, 10.0 );
45-
}
33+
var options = {
34+
'dtype': 'float32'
35+
};
36+
37+
38+
// FUNCTIONS //
4639

4740
/**
4841
* Creates a benchmark function.
@@ -52,7 +45,7 @@ function rand() {
5245
* @returns {Function} benchmark function
5346
*/
5447
function createBenchmark( len ) {
55-
var x = filledarrayBy( len, 'float32', rand );
48+
var x = uniform( len, -10.0, 10.0, options );
5649
return benchmark;
5750

5851
function benchmark( b ) {

lib/node_modules/@stdlib/stats/base/dsmeanors/benchmark/benchmark.ndarray.native.js

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var uniform = require( '@stdlib/random/base/uniform' );
26-
var bernoulli = require( '@stdlib/random/base/bernoulli' );
27-
var filledarrayBy = require( '@stdlib/array/filled-by' );
2826
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2927
var pow = require( '@stdlib/math/base/special/pow' );
3028
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -37,22 +35,13 @@ var dsmeanors = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) )
3735
var opts = {
3836
'skip': ( dsmeanors instanceof Error )
3937
};
38+
var options = {
39+
'dtype': 'float32'
40+
};
4041

4142

4243
// FUNCTIONS //
4344

44-
/**
45-
* Returns a random value or `NaN`.
46-
*
47-
* @returns {number} random number or `NaN`
48-
*/
49-
function rand() {
50-
if ( bernoulli( 0.2 ) ) {
51-
return NaN;
52-
}
53-
return uniform( -10.0, 10.0 );
54-
}
55-
5645
/**
5746
* Creates a benchmark function.
5847
*
@@ -61,7 +50,7 @@ function rand() {
6150
* @returns {Function} benchmark function
6251
*/
6352
function createBenchmark( len ) {
64-
var x = filledarrayBy( len, 'float32', rand );
53+
var x = uniform( len, -10.0, 10.0, options );
6554
return benchmark;
6655

6756
function benchmark( b ) {

lib/node_modules/@stdlib/stats/base/dsmeanors/benchmark/c/benchmark.length.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,14 @@ static float rand_float( void ) {
9797
static double benchmark1( int iterations, int len ) {
9898
double elapsed;
9999
float x[ len ];
100-
double v;
100+
float v;
101101
double t;
102102
int i;
103103

104104
for ( i = 0; i < len; i++ ) {
105105
x[ i ] = ( rand_float()*20000.0f ) - 10000.0f;
106106
}
107-
v = 0.0;
107+
v = 0.0f;
108108
t = tic();
109109
for ( i = 0; i < iterations; i++ ) {
110110
// cppcheck-suppress uninitvar
@@ -131,18 +131,14 @@ static double benchmark1( int iterations, int len ) {
131131
static double benchmark2( int iterations, int len ) {
132132
double elapsed;
133133
float x[ len ];
134-
double v;
134+
float v;
135135
double t;
136136
int i;
137137

138138
for ( i = 0; i < len; i++ ) {
139-
if ( rand_float() < 0.2f ) {
140-
x[ i ] = 0.0f / 0.0f; // NaN
141-
} else {
142-
x[ i ] = ( rand_float() * 20000.0f ) - 10000.0f;
143-
}
139+
x[ i ] = ( rand_float() * 20000.0f ) - 10000.0f;
144140
}
145-
v = 0.0;
141+
v = 0.0f;
146142
t = tic();
147143
for ( i = 0; i < iterations; i++ ) {
148144
// cppcheck-suppress uninitvar

0 commit comments

Comments
 (0)