Skip to content

Commit de931cd

Browse files
chore: stuff from code review
1 parent 4f8b523 commit de931cd

File tree

5 files changed

+17
-12
lines changed

5 files changed

+17
-12
lines changed

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/benchmark/benchmark.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
26+
var FLOAT32_SQRT_HALF = require( '@stdlib/constants/float32/sqrt-half' );
27+
var FLOAT32_SQRT2 = require( '@stdlib/constants/float32/sqrt-two' );
2628
var pkg = require( './../package.json' ).name;
2729
var kernelLog1pf = require( './../lib' );
2830

@@ -34,7 +36,7 @@ bench( pkg, function benchmark( b ) {
3436
var y;
3537
var i;
3638

37-
x = uniform( 100, 0.70710677, 1.0 );
39+
x = uniform( 100, FLOAT32_SQRT_HALF, 2.0 / FLOAT32_SQRT2 );
3840

3941
b.tic();
4042
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/benchmark/benchmark.native.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var uniform = require( '@stdlib/random/array/uniform' );
26+
var FLOAT32_SQRT_HALF = require( '@stdlib/constants/float32/sqrt-half' );
27+
var FLOAT32_SQRT2 = require( '@stdlib/constants/float32/sqrt-two' );
2628
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2729
var tryRequire = require( '@stdlib/utils/try-require' );
2830
var pkg = require( './../package.json' ).name;
@@ -43,7 +45,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4345
var y;
4446
var i;
4547

46-
x = uniform( 100, 0.70710677, 1.0 );
48+
x = uniform( 100, FLOAT32_SQRT_HALF, 2.0 / FLOAT32_SQRT2 );
4749

4850
b.tic();
4951
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/lib/main.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636

3737
var polyvalP = require( './polyval_p.js' );
3838
var polyvalQ = require( './polyval_q.js' );
39+
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
3940

4041

4142
// MAIN //
@@ -140,14 +141,14 @@ function kernelLog1pf( f ) {
140141
var R;
141142
var w;
142143

143-
s = f / ( 2.0 + f );
144-
z = s * s;
145-
w = z * z;
146-
t1 = w * polyvalP( w );
147-
t2 = z * polyvalQ( w );
148-
R = t2 + t1;
149-
hfsq = 0.5 * f * f;
150-
return s * ( hfsq + R );
144+
s = float64ToFloat32( f / float64ToFloat32( 2.0 + f ) );
145+
z = float64ToFloat32( s * s );
146+
w = float64ToFloat32( z * z );
147+
t1 = float64ToFloat32( w * polyvalP( w ) );
148+
t2 = float64ToFloat32( z * polyvalQ( w ) );
149+
R = float64ToFloat32( t2 + t1 );
150+
hfsq = float64ToFloat32( 0.5 * f * f );
151+
return float64ToFloat32( s * float64ToFloat32( hfsq + R ) );
151152
}
152153

153154

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ tape( 'the function correctly computes `logf(1+f) - f` for `1+f` satisfying `sqr
6565
t.equal( y, e, 'x: '+x[ i ]+'. E: '+e );
6666
} else {
6767
delta = absf( y - e );
68-
tol = 130.0 * EPS * absf( e );
68+
tol = 1.0 * EPS * absf( e );
6969
t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' );
7070
}
7171
}

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.native.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ tape( 'the function correctly computes `logf(1+f) - f` for `1+f` satisfying `sqr
7474
t.equal( y, e, 'x: '+x[ i ]+'. E: '+e );
7575
} else {
7676
delta = absf( y - e );
77-
tol = 130.0 * EPS * absf( e );
77+
tol = 1.0 * EPS * absf( e );
7878
t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' );
7979
}
8080
}

0 commit comments

Comments
 (0)