Skip to content

Commit 499fd1d

Browse files
Dev Jaingregkh
authored andcommitted
selftests/mm: compaction_test: fix incorrect write of zero to nr_hugepages
[ Upstream commit 9ad665e ] Currently, the test tries to set nr_hugepages to zero, but that is not actually done because the file offset is not reset after read(). Fix that using lseek(). Link: https://lkml.kernel.org/r/[email protected] Fixes: bd67d5c ("Test compaction of mlocked memory") Signed-off-by: Dev Jain <[email protected]> Cc: <[email protected]> Cc: Anshuman Khandual <[email protected]> Cc: Shuah Khan <[email protected]> Cc: Sri Jayaramappa <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 198a808 commit 499fd1d

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

tools/testing/selftests/vm/compaction_test.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ int check_compaction(unsigned long mem_free, unsigned int hugepage_size)
103103
goto close_fd;
104104
}
105105

106+
lseek(fd, 0, SEEK_SET);
107+
106108
/* Start with the initial condition of 0 huge pages*/
107109
if (write(fd, "0", sizeof(char)) != sizeof(char)) {
108110
perror("Failed to write 0 to /proc/sys/vm/nr_hugepages\n");

0 commit comments

Comments
 (0)