Enhance CI workflow and code quality checks; update Alembic migration scripts and improve code formatting. Added new steps for code quality checks using Black, Ruff, and Mypy in the CI pipeline. Refactored migration scripts for consistency and clarity. Updated FastAPI routes to improve type hints and formatting.

Author: Neiland85

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -0,0 +1,40 @@
+name: Bug Report
+description: Reporta un fallo reproducible en la app
+labels: [bug]
+title: "bug: [componente] resumen breve"
+body:
+  - type: textarea
+    id: resumen
+    attributes:
+      label: Resumen
+      description: ¿Qué está pasando?
+      placeholder: Descripción breve del bug
+    validations:
+      required: true
+  - type: textarea
+    id: pasos
+    attributes:
+      label: Pasos para reproducir
+      description: Cómo reproducir el problema
+      placeholder: |
+        1. ...
+        2. ...
+        3. ...
+    validations:
+      required: true
+  - type: textarea
+    id: esperado
+    attributes:
+      label: Comportamiento esperado
+    validations:
+      required: true
+  - type: input
+    id: version
+    attributes:
+      label: Versión/commit
+      placeholder: vX.Y.Z o SHA
+  - type: textarea
+    id: logs
+    attributes:
+      label: Logs relevantes
+      render: shell

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,5 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Q&A / Soporte
+    url: https://github.com/OWNER/REPO/discussions
+    about: Usa Discussions para preguntas generales.

.github/ISSUE_TEMPLATE/lint_error.yml

@@ -0,0 +1,33 @@
+name: Lint/Build Error
+description: Error de linter, type-check o build (creado desde logs)
+labels: [lint, automation]
+title: "lint: [tool] breve mensaje"
+body:
+  - type: input
+    id: tool
+    attributes:
+      label: Herramienta
+      placeholder: ruff | mypy | pytest | eslint | otros
+    validations:
+      required: true
+  - type: input
+    id: archivo
+    attributes:
+      label: Archivo
+      placeholder: ruta/archivo:línea
+  - type: textarea
+    id: mensaje
+    attributes:
+      label: Mensaje
+      description: Mensaje exacto del error
+    validations:
+      required: true
+  - type: textarea
+    id: reproduccion
+    attributes:
+      label: Reproducción
+      description: Comando exacto para reproducir
+      placeholder: |
+        ejemplo: ruff check app/
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/tech_debt.yml

@@ -0,0 +1,24 @@
+name: Tech Debt
+description: Trabajo de mantenimiento o refactor sin bug directo
+labels: [tech-debt]
+title: "debt: [área] resumen breve"
+body:
+  - type: textarea
+    id: motivacion
+    attributes:
+      label: Motivación / Riesgo
+      description: ¿Por qué es necesario?
+    validations:
+      required: true
+  - type: textarea
+    id: alcance
+    attributes:
+      label: Alcance
+      description: Qué archivos o módulos toca
+    validations:
+      required: true
+  - type: textarea
+    id: criterio
+    attributes:
+      label: Criterios de aceptación
+      description: Definición de Done

.github/workflows/ci.yml

@@ -1,4 +1,4 @@
-name: CI
+name: CI 🧪 FastAPI Quality Pipeline
 
 on:
   pull_request:
@@ -9,37 +9,61 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
+
     steps:
-      - name: Checkout
+      - name: 📥 Checkout repository
         uses: actions/checkout@v4
 
-      - name: Set up Python
+      - name: 🐍 Set up Python
         uses: actions/setup-python@v5
         with:
           python-version: '3.11'
 
-      - name: Install dependencies
+      - name: 📦 Install dependencies
         run: |
           python -m pip install --upgrade pip
           if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
           if [ -f requirements-dev.txt ]; then pip install -r requirements-dev.txt || true; fi
+          pip install black isort ruff mypy pre-commit yamllint
 
-      - name: Prepare env
+      - name: ⚙️ Prepare environment
         run: |
           cp .env.example .env || true
         env:
-          # Defaults for CI
           ENVIRONMENT: testing
 
-      - name: Run Alembic migrations
+      - name: 🧼 Code Quality Checks
+        run: |
+          echo "Running Black, Ruff, and Mypy checks..."
+          black --check .
+          isort --check-only .
+          ruff check .
+          mypy --install-types --non-interactive .
+          echo "✅ Code Quality stage completed."
+
+      - name: 🧩 Pre-commit hooks
+        run: |
+          pre-commit run --all-files || true
+        continue-on-error: true
+
+      - name: 🧱 Run Alembic migrations
         env:
           DATABASE_URL: sqlite+aiosqlite:///./test.db
         run: |
           alembic upgrade head
 
-      - name: Run tests
+      - name: 🧪 Run tests (pytest)
         env:
           DATABASE_URL: sqlite+aiosqlite:///./test.db
           PYTEST_ADDOPTS: "-q"
         run: |
-          pytest
+          pytest --maxfail=1 --disable-warnings -q
+
+      - name: 📊 Upload coverage
+        if: success()
+        uses: codecov/codecov-action@v4
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          files: ./coverage.xml
+          fail_ci_if_error: false
+          verbose: true

alembic/env.py

@@ -2,11 +2,11 @@
 import os
 from logging.config import fileConfig
 
+from alembic import context
 from sqlalchemy import pool
 from sqlalchemy.engine import Connection
 from sqlalchemy.ext.asyncio import async_engine_from_config
 
-from alembic import context
 from app import models  # noqa: F401 - ensure models are imported
 from app.database import Base
 

alembic/versions/8fe0bc0038f8_init_rbac.py

@@ -5,11 +5,12 @@
 Create Date: 2025-10-30 10:58:02.168458
 
 """
-from alembic import op
+
 import sqlalchemy as sa
+from alembic import op
 
 # revision identifiers, used by Alembic.
-revision = '8fe0bc0038f8'
+revision = "8fe0bc0038f8"
 down_revision = None
 branch_labels = None
 depends_on = None
@@ -18,88 +19,103 @@
 def upgrade() -> None:
     # Roles
     op.create_table(
-        'roles',
-        sa.Column('id', sa.String(length=36), primary_key=True, nullable=False),
-        sa.Column('name', sa.String(length=50), nullable=False),
-        sa.Column('description', sa.String(length=255), nullable=True),
-        sa.Column('created_at', sa.DateTime(timezone=True), nullable=False),
-        sa.Column('updated_at', sa.DateTime(timezone=True), nullable=False),
-        sa.UniqueConstraint('name', name='uq_roles_name'),
+        "roles",
+        sa.Column("id", sa.String(length=36), primary_key=True, nullable=False),
+        sa.Column("name", sa.String(length=50), nullable=False),
+        sa.Column("description", sa.String(length=255), nullable=True),
+        sa.Column("created_at", sa.DateTime(timezone=True), nullable=False),
+        sa.Column("updated_at", sa.DateTime(timezone=True), nullable=False),
+        sa.UniqueConstraint("name", name="uq_roles_name"),
     )
-    op.create_index('ix_roles_name', 'roles', ['name'], unique=True)
+    op.create_index("ix_roles_name", "roles", ["name"], unique=True)
 
     # Permissions
     op.create_table(
-        'permissions',
-        sa.Column('id', sa.String(length=36), primary_key=True, nullable=False),
-        sa.Column('name', sa.String(length=100), nullable=False),
-        sa.Column('resource', sa.String(length=50), nullable=False),
-        sa.Column('action', sa.String(length=50), nullable=False),
-        sa.Column('description', sa.String(length=255), nullable=True),
-        sa.UniqueConstraint('name', name='uq_permissions_name'),
+        "permissions",
+        sa.Column("id", sa.String(length=36), primary_key=True, nullable=False),
+        sa.Column("name", sa.String(length=100), nullable=False),
+        sa.Column("resource", sa.String(length=50), nullable=False),
+        sa.Column("action", sa.String(length=50), nullable=False),
+        sa.Column("description", sa.String(length=255), nullable=True),
+        sa.UniqueConstraint("name", name="uq_permissions_name"),
     )
-    op.create_index('ix_permissions_name', 'permissions', ['name'], unique=True)
-    op.create_index('ix_permissions_resource', 'permissions', ['resource'], unique=False)
-    op.create_index('ix_permissions_action', 'permissions', ['action'], unique=False)
+    op.create_index("ix_permissions_name", "permissions", ["name"], unique=True)
+    op.create_index(
+        "ix_permissions_resource", "permissions", ["resource"], unique=False
+    )
+    op.create_index("ix_permissions_action", "permissions", ["action"], unique=False)
 
     # Users
     op.create_table(
-        'users',
-        sa.Column('id', sa.String(length=36), primary_key=True, nullable=False),
-        sa.Column('username', sa.String(length=50), nullable=False),
-        sa.Column('email', sa.String(length=255), nullable=False),
-        sa.Column('hashed_password', sa.String(length=255), nullable=False),
-        sa.Column('full_name', sa.String(length=255), nullable=True),
-        sa.Column('is_active', sa.Boolean(), nullable=False, server_default=sa.text('1')),
-        sa.Column('is_superuser', sa.Boolean(), nullable=False, server_default=sa.text('0')),
-        sa.Column('created_at', sa.DateTime(timezone=True), nullable=False),
-        sa.Column('updated_at', sa.DateTime(timezone=True), nullable=False),
-        sa.UniqueConstraint('username', name='uq_users_username'),
-        sa.UniqueConstraint('email', name='uq_users_email'),
+        "users",
+        sa.Column("id", sa.String(length=36), primary_key=True, nullable=False),
+        sa.Column("username", sa.String(length=50), nullable=False),
+        sa.Column("email", sa.String(length=255), nullable=False),
+        sa.Column("hashed_password", sa.String(length=255), nullable=False),
+        sa.Column("full_name", sa.String(length=255), nullable=True),
+        sa.Column(
+            "is_active", sa.Boolean(), nullable=False, server_default=sa.text("1")
+        ),
+        sa.Column(
+            "is_superuser", sa.Boolean(), nullable=False, server_default=sa.text("0")
+        ),
+        sa.Column("created_at", sa.DateTime(timezone=True), nullable=False),
+        sa.Column("updated_at", sa.DateTime(timezone=True), nullable=False),
+        sa.UniqueConstraint("username", name="uq_users_username"),
+        sa.UniqueConstraint("email", name="uq_users_email"),
     )
-    op.create_index('ix_users_username', 'users', ['username'], unique=True)
-    op.create_index('ix_users_email', 'users', ['email'], unique=True)
+    op.create_index("ix_users_username", "users", ["username"], unique=True)
+    op.create_index("ix_users_email", "users", ["email"], unique=True)
 
     # Association: user_roles
     op.create_table(
-        'user_roles',
-        sa.Column('user_id', sa.String(length=36), nullable=False),
-        sa.Column('role_id', sa.String(length=36), nullable=False),
-        sa.ForeignKeyConstraint(['user_id'], ['users.id'], ondelete='CASCADE'),
-        sa.ForeignKeyConstraint(['role_id'], ['roles.id'], ondelete='CASCADE'),
+        "user_roles",
+        sa.Column("user_id", sa.String(length=36), nullable=False),
+        sa.Column("role_id", sa.String(length=36), nullable=False),
+        sa.ForeignKeyConstraint(["user_id"], ["users.id"], ondelete="CASCADE"),
+        sa.ForeignKeyConstraint(["role_id"], ["roles.id"], ondelete="CASCADE"),
     )
-    op.create_index('ix_user_roles_user_id', 'user_roles', ['user_id'], unique=False)
-    op.create_index('ix_user_roles_role_id', 'user_roles', ['role_id'], unique=False)
+    op.create_index("ix_user_roles_user_id", "user_roles", ["user_id"], unique=False)
+    op.create_index("ix_user_roles_role_id", "user_roles", ["role_id"], unique=False)
 
     # Association: role_permissions
     op.create_table(
-        'role_permissions',
-        sa.Column('role_id', sa.String(length=36), nullable=False),
-        sa.Column('permission_id', sa.String(length=36), nullable=False),
-        sa.ForeignKeyConstraint(['role_id'], ['roles.id'], ondelete='CASCADE'),
-        sa.ForeignKeyConstraint(['permission_id'], ['permissions.id'], ondelete='CASCADE'),
+        "role_permissions",
+        sa.Column("role_id", sa.String(length=36), nullable=False),
+        sa.Column("permission_id", sa.String(length=36), nullable=False),
+        sa.ForeignKeyConstraint(["role_id"], ["roles.id"], ondelete="CASCADE"),
+        sa.ForeignKeyConstraint(
+            ["permission_id"], ["permissions.id"], ondelete="CASCADE"
+        ),
+    )
+    op.create_index(
+        "ix_role_permissions_role_id", "role_permissions", ["role_id"], unique=False
+    )
+    op.create_index(
+        "ix_role_permissions_permission_id",
+        "role_permissions",
+        ["permission_id"],
+        unique=False,
     )
-    op.create_index('ix_role_permissions_role_id', 'role_permissions', ['role_id'], unique=False)
-    op.create_index('ix_role_permissions_permission_id', 'role_permissions', ['permission_id'], unique=False)
 
 
 def downgrade() -> None:
-    op.drop_index('ix_role_permissions_permission_id', table_name='role_permissions')
-    op.drop_index('ix_role_permissions_role_id', table_name='role_permissions')
-    op.drop_table('role_permissions')
+    op.drop_index("ix_role_permissions_permission_id", table_name="role_permissions")
+    op.drop_index("ix_role_permissions_role_id", table_name="role_permissions")
+    op.drop_table("role_permissions")
 
-    op.drop_index('ix_user_roles_role_id', table_name='user_roles')
-    op.drop_index('ix_user_roles_user_id', table_name='user_roles')
-    op.drop_table('user_roles')
+    op.drop_index("ix_user_roles_role_id", table_name="user_roles")
+    op.drop_index("ix_user_roles_user_id", table_name="user_roles")
+    op.drop_table("user_roles")
 
-    op.drop_index('ix_users_email', table_name='users')
-    op.drop_index('ix_users_username', table_name='users')
-    op.drop_table('users')
+    op.drop_index("ix_users_email", table_name="users")
+    op.drop_index("ix_users_username", table_name="users")
+    op.drop_table("users")
 
-    op.drop_index('ix_permissions_action', table_name='permissions')
-    op.drop_index('ix_permissions_resource', table_name='permissions')
-    op.drop_index('ix_permissions_name', table_name='permissions')
-    op.drop_table('permissions')
+    op.drop_index("ix_permissions_action", table_name="permissions")
+    op.drop_index("ix_permissions_resource", table_name="permissions")
+    op.drop_index("ix_permissions_name", table_name="permissions")
+    op.drop_table("permissions")
 
-    op.drop_index('ix_roles_name', table_name='roles')
-    op.drop_table('roles')
+    op.drop_index("ix_roles_name", table_name="roles")
+    op.drop_table("roles")

app/backoffice/router.py

@@ -124,11 +124,14 @@ async def search_transactions(
                 "status": random.choice(  # nosec B311
                     ["completed", "pending", "failed", "cancelled"]
                 ),
-                "type": random.choice(["transfer", "deposit", "withdrawal", "payment"]),  # nosec B311
+                "type": random.choice(
+                    ["transfer", "deposit", "withdrawal", "payment"]
+                ),  # nosec B311
                 "user_id": random.randint(1000, 9999),  # nosec B311
                 "description": f"Transaction {tx_id}",
                 "created_at": (
-                    datetime.now() - timedelta(hours=random.randint(1, 72))  # nosec B311
+                    datetime.now()
+                    - timedelta(hours=random.randint(1, 72))  # nosec B311
                 ).isoformat(),
             }
         )