Merge pull request misd-service-development#201 from odolbeau/support-phone-number-format-as-string

Remove deprecations notice + update doc

Author: Nek-

README.md

@@ -108,8 +108,10 @@ The `phone_number_format` filter can be used to format a phone number object. A
 
 For example, to format an object called `myPhoneNumber` in the `libphonenumber\PhoneNumberFormat::NATIONAL` format:
 
-```php
+```twig
 {{ myPhoneNumber|phone_number_format('NATIONAL') }}
+{# or #}
+{{ myPhoneNumber|phone_number_format(enum('libphonenumber\PhoneNumberFormat').NATIONAL) }}
 ```
 
 By default phone numbers are formatted in the `libphonenumber\PhoneNumberFormat::INTERNATIONAL` format.
@@ -120,7 +122,7 @@ The `phone_number_of_type` test can be used to check a phone number against a ty
 
 For example, to check if an object called `myPhoneNumber` is a `libphonenumber\PhoneNumberType::MOBILE` type:
 
-```php
+```twig
 {% if myPhoneNumber is phone_number_of_type('MOBILE') }} %} ... {% endif %}
 ```
 
@@ -240,7 +242,7 @@ public function getCountryCode()
 }
 ```
 
-By default any valid phone number will be accepted. You can restrict the type through the `type` property, recognised values:
+By default, any valid phone number will be accepted. You can restrict the type through the `type` property, recognised values:
 
 - `Misd\PhoneNumberBundle\Validator\Constraints\PhoneNumber::ANY` (default)
 - `Misd\PhoneNumberBundle\Validator\Constraints\PhoneNumber::FIXED_LINE`

src/Templating/Helper/PhoneNumberHelper.php

@@ -35,8 +35,6 @@ public function format(PhoneNumber|string $phoneNumber, string|int|PhoneNumberFo
         $phoneNumber = $this->getPhoneNumber($phoneNumber);
 
         if (true === \is_string($format)) {
-            trigger_deprecation('odolbeau/phone-number-bundle', '4.2', 'Passing a string to the "format" parameter is deprecated, pass a libphonenumber\PhoneNumberFormat instance instead.');
-
             $constant = '\libphonenumber\PhoneNumberFormat::'.$format;
             if (false === \defined($constant)) {
                 throw new InvalidArgumentException('The format must be either a constant value or name in libphonenumber\PhoneNumberFormat');