UpdateRules: optimize out HasIncludes() usage

dmaluka · dmaluka · commit 08c516c73007 · 2024-04-21T15:14:21.000+02:00
diff --git a/internal/buffer/buffer.go b/internal/buffer/buffer.go
@@ -741,10 +741,10 @@ func findRuntimeSyntaxDef(name string, header *highlight.Header) *highlight.Def
 }
 
 func resolveIncludes(syndef *highlight.Def) {
-	if !highlight.HasIncludes(syndef) {
+	includes := highlight.GetIncludes(syndef)
+	if len(includes) == 0 {
 		return
 	}
-	includes := highlight.GetIncludes(syndef)
 
 	var files []*highlight.File
 	for _, f := range config.ListRuntimeFiles(config.RTSyntax) {

Original file line number	Diff line number	Diff line change
`@@ -741,10 +741,10 @@ func findRuntimeSyntaxDef(name string, header highlight.Header) highlight.Def`
`741`	`741`	`}`
`742`	`742`
`743`	`743`	`func resolveIncludes(syndef *highlight.Def) {`
`744`		`- if !highlight.HasIncludes(syndef) {`
	`744`	`+ includes := highlight.GetIncludes(syndef)`
	`745`	`+ if len(includes) == 0 {`
`745`	`746`	`return`
`746`	`747`	`}`
`747`		`- includes := highlight.GetIncludes(syndef)`
`748`	`748`
`749`	`749`	`var files []*highlight.File`
`750`	`750`	`for _, f := range config.ListRuntimeFiles(config.RTSyntax) {`