Skip to content

Commit 3dc02dd

Browse files
Adding missing file closes
1 parent 7492195 commit 3dc02dd

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

internal/buffer/buffer.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,7 @@ func (b *Buffer) ReOpen() error {
537537
if err != nil {
538538
return err
539539
}
540+
defer file.Close()
540541

541542
enc, err := htmlindex.Get(b.Settings["encoding"].(string))
542543
if err != nil {

internal/buffer/save.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,9 +356,11 @@ func (b *Buffer) safeWrite(path string, withSudo bool, newFile bool) (int, error
356356
backupDir := b.backupDir()
357357
if _, err := os.Stat(backupDir); err != nil {
358358
if !errors.Is(err, fs.ErrNotExist) {
359+
file.Close()
359360
return 0, err
360361
}
361362
if err = os.Mkdir(backupDir, os.ModePerm); err != nil {
363+
file.Close()
362364
return 0, err
363365
}
364366
}
@@ -367,13 +369,15 @@ func (b *Buffer) safeWrite(path string, withSudo bool, newFile bool) (int, error
367369
_, err = b.overwriteFile(backupName)
368370
if err != nil {
369371
os.Remove(backupName)
372+
file.Close()
370373
return 0, err
371374
}
372375

373376
b.forceKeepBackup = true
374377
size, err := file.Write(b)
375378
if err != nil {
376379
err = util.OverwriteError{err, backupName}
380+
file.Close()
377381
return size, err
378382
}
379383
b.forceKeepBackup = false

0 commit comments

Comments
 (0)