Fix Deselect() after mouse selection (zyedidia#3268)

dmaluka · web-flow · commit 3f810c24d231 · 2024-04-25T21:58:40.000+02:00
Ensure that the selection start is always before the selection end, regardless of the direction of a mouse selection, to make h.Cursor.Deselect() handle its `start` argument correctly. This makes the cursor behavior after mouse selections consistent with the cursor behavior after keyboard selections. Fixes zyedidia#3055
diff --git a/internal/action/actions.go b/internal/action/actions.go
@@ -113,7 +113,7 @@ func (h *BufPane) MouseDrag(e *tcell.EventMouse) bool {
 	} else if h.doubleClick {
 		h.Cursor.AddWordToSelection()
 	} else {
-		h.Cursor.SetSelectionEnd(h.Cursor.Loc)
+		h.Cursor.SelectTo(h.Cursor.Loc)
 	}
 
 	h.Cursor.StoreVisualX()

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ func (h BufPane) MouseDrag(e tcell.EventMouse) bool {`
`113`	`113`	`} else if h.doubleClick {`
`114`	`114`	`h.Cursor.AddWordToSelection()`
`115`	`115`	`} else {`
`116`		`- h.Cursor.SetSelectionEnd(h.Cursor.Loc)`
	`116`	`+ h.Cursor.SelectTo(h.Cursor.Loc)`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`h.Cursor.StoreVisualX()`