Skip to content

Commit 46ff434

Browse files
Adding missing file closes
1 parent 7492195 commit 46ff434

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

internal/buffer/buffer.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,10 @@ func NewBufferFromFileAtLoc(path string, btype BufType, cursorLoc Loc) (*Buffer,
254254
f.Close()
255255

256256
file, err := os.Open(filename)
257-
if err == nil {
258-
defer file.Close()
257+
if err != nil {
258+
return nil, err
259259
}
260+
defer file.Close()
260261

261262
var buf *Buffer
262263
if errors.Is(err, fs.ErrNotExist) {
@@ -537,6 +538,7 @@ func (b *Buffer) ReOpen() error {
537538
if err != nil {
538539
return err
539540
}
541+
defer file.Close()
540542

541543
enc, err := htmlindex.Get(b.Settings["encoding"].(string))
542544
if err != nil {

internal/buffer/save.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,7 @@ func (b *Buffer) safeWrite(path string, withSudo bool, newFile bool) (int, error
374374
size, err := file.Write(b)
375375
if err != nil {
376376
err = util.OverwriteError{err, backupName}
377+
file.Close()
377378
return size, err
378379
}
379380
b.forceKeepBackup = false

0 commit comments

Comments
 (0)