Skip to content

Commit a49a6a3

Browse files
Adding missing file closes
1 parent fc3ed74 commit a49a6a3

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

internal/buffer/buffer.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,10 @@ func NewBufferFromFileAtLoc(path string, btype BufType, cursorLoc Loc) (*Buffer,
255255
f.Close()
256256

257257
file, err := os.Open(filename)
258-
if err == nil {
259-
defer file.Close()
258+
if err != nil {
259+
return nil, err
260260
}
261+
defer file.Close()
261262

262263
var buf *Buffer
263264
if errors.Is(err, fs.ErrNotExist) {
@@ -538,6 +539,7 @@ func (b *Buffer) ReOpen() error {
538539
if err != nil {
539540
return err
540541
}
542+
defer file.Close()
541543

542544
enc, err := htmlindex.Get(b.Settings["encoding"].(string))
543545
if err != nil {

internal/buffer/save.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,7 @@ func (b *Buffer) safeWrite(path string, withSudo bool, newFile bool) (int, error
374374
size, err := file.Write(b)
375375
if err != nil {
376376
err = util.OverwriteError{err, backupName}
377+
file.Close()
377378
return size, err
378379
}
379380
b.forceKeepBackup = false

0 commit comments

Comments
 (0)