Skip to content

Commit b05df07

Browse files
committed
bindings: Small refactoring of TryBindKey() for better readability
1 parent 8af890a commit b05df07

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

internal/action/bindings.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -294,21 +294,23 @@ func TryBindKey(k, v string, overwrite bool) (bool, error) {
294294
}
295295

296296
found := false
297-
for ev := range parsed {
297+
var ev string
298+
for ev = range parsed {
298299
if e, err := findEvent(ev); err == nil {
299300
if eventsEqual(e, key) {
300-
if overwrite {
301-
parsed[ev] = v
302-
}
303301
found = true
304302
break
305303
}
306304
}
307305
}
308306

309-
if found && !overwrite {
310-
return true, nil
311-
} else if !found {
307+
if found {
308+
if overwrite {
309+
parsed[ev] = v
310+
} else {
311+
return true, nil
312+
}
313+
} else {
312314
parsed[k] = v
313315
}
314316

0 commit comments

Comments
 (0)