Reordered prompt done callback to avoid accessing out of bound history (zyedidia#3318)

Neko-Box-Coder · web-flow · commit dd913df9e9b9 · 2024-06-02T20:00:13.000+02:00
* Reordered prompt done callback to avoid accessing out of bound history

* Formatting
diff --git a/internal/info/infobuffer.go b/internal/info/infobuffer.go
@@ -143,13 +143,12 @@ func (i *InfoBuf) DonePrompt(canceled bool) {
 		if i.PromptCallback != nil {
 			if canceled {
 				i.Replace(i.Start(), i.End(), "")
-				i.PromptCallback("", true)
 				h := i.History[i.PromptType]
 				i.History[i.PromptType] = h[:len(h)-1]
+				i.PromptCallback("", true)
 			} else {
 				resp := string(i.LineBytes(0))
 				i.Replace(i.Start(), i.End(), "")
-				i.PromptCallback(resp, false)
 				h := i.History[i.PromptType]
 				h[len(h)-1] = resp
 
@@ -160,6 +159,8 @@ func (i *InfoBuf) DonePrompt(canceled bool) {
 						break
 					}
 				}
+
+				i.PromptCallback(resp, false)
 			}
 			// i.PromptCallback = nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -143,13 +143,12 @@ func (i *InfoBuf) DonePrompt(canceled bool) {`
`143`	`143`	`if i.PromptCallback != nil {`
`144`	`144`	`if canceled {`
`145`	`145`	`i.Replace(i.Start(), i.End(), "")`
`146`		`- i.PromptCallback("", true)`
`147`	`146`	`h := i.History[i.PromptType]`
`148`	`147`	`i.History[i.PromptType] = h[:len(h)-1]`
	`148`	`+ i.PromptCallback("", true)`
`149`	`149`	`} else {`
`150`	`150`	`resp := string(i.LineBytes(0))`
`151`	`151`	`i.Replace(i.Start(), i.End(), "")`
`152`		`- i.PromptCallback(resp, false)`
`153`	`152`	`h := i.History[i.PromptType]`
`154`	`153`	`h[len(h)-1] = resp`
`155`	`154`
`@@ -160,6 +159,8 @@ func (i *InfoBuf) DonePrompt(canceled bool) {`
`160`	`159`	`break`
`161`	`160`	`}`
`162`	`161`	`}`
	`162`	`+`
	`163`	`+ i.PromptCallback(resp, false)`
`163`	`164`	`}`
`164`	`165`	`// i.PromptCallback = nil`
`165`	`166`	`}`