Minor checks and formatting fixes

Author: Neko-Box-Coder

Include/runcpp2/Data/BuildTypeHelper.hpp

@@ -21,8 +21,8 @@ namespace runcpp2
             bool GetOutputPath( const ghc::filesystem::path& buildDir,
                                 const std::string& scriptName,
                                 const Profile& profile,
-                                BuildType buildType,
-                                bool asExecutable,
+                                const BuildType buildType,
+                                const bool asExecutable,
                                 ghc::filesystem::path& outPath);
         }
     }

Include/runcpp2/Data/StageInfo.hpp

@@ -56,8 +56,8 @@ namespace runcpp2
                                             std::string& inOutSubstitutedString) const;
 
                 bool ConstructCommand(  const SubstitutionMap& substitutionMap, 
-                                        bool isExecutable,
-                                        BuildType buildType,
+                                        const bool isExecutable,
+                                        const BuildType buildType,
                                         std::string& outCommand) const;
 
                 bool ParseYAML_Node(ryml::ConstNodeRef& node, std::string outputTypeKeyName);

Src/Tests/Data/BuildTypeTest.cpp

@@ -86,8 +86,11 @@ int main(int argc, char** argv)
             runcpp2::Data::FilesTypesInfo filesTypes;
         );
 
-        ssTEST_OUTPUT_ASSERT("Static build type",
-            BuildTypeHelper::GetOutputFileProperties(filesTypes, BuildType::STATIC, false) == &filesTypes.StaticLinkFile);
+        ssTEST_OUTPUT_ASSERT(   "Static build type",
+                                BuildTypeHelper::GetOutputFileProperties(   filesTypes, 
+                                                                            BuildType::STATIC, 
+                                                                            false), 
+                                &filesTypes.StaticLinkFile);
     };
 
     ssTEST_END_TEST_GROUP();

Src/runcpp2/Data/BuildTypeHelper.cpp

@@ -13,6 +13,7 @@ namespace runcpp2
         if(buildType == BuildType::EXECUTABLE && asExecutable)
             return nullptr;
 
+        static_assert(static_cast<int>(BuildType::COUNT) == 4, "Update This");
         switch(buildType)
         {
             case BuildType::EXECUTABLE:
@@ -35,8 +36,8 @@ namespace runcpp2
     bool Data::BuildTypeHelper::GetOutputPath(const ghc::filesystem::path& buildDir,
                                               const std::string& scriptName,
                                               const Profile& profile,
-                                              BuildType buildType,
-                                              bool asExecutable,
+                                              const BuildType buildType,
+                                              const bool asExecutable,
                                               ghc::filesystem::path& outPath)
     {
         //For executable build type with executable flag, use platform-specific extension
@@ -50,8 +51,9 @@ namespace runcpp2
             return true;
         }
 
-        const FileProperties* fileTypeInfo = 
-            GetOutputFileProperties(profile.FilesTypes, buildType, asExecutable);
+        const FileProperties* fileTypeInfo = GetOutputFileProperties(   profile.FilesTypes, 
+                                                                        buildType, 
+                                                                        asExecutable);
         if(!fileTypeInfo)
             return false;
 

Src/runcpp2/Data/StageInfo.cpp

@@ -313,8 +313,8 @@ bool runcpp2::Data::StageInfo::PerformSubstituions( const SubstitutionMap& subst
 }
 
 bool runcpp2::Data::StageInfo::ConstructCommand(const SubstitutionMap& substitutionMap, 
-                                                bool isExecutable,
-                                                BuildType buildType,
+                                                const bool isExecutable,
+                                                const BuildType buildType,
                                                 std::string& outCommand) const
 {
     ssLOG_FUNC_DEBUG();   

Src/runcpp2/PipelineSteps.cpp

@@ -176,18 +176,18 @@ namespace
     }
 
     bool GetOutputFileInfo( const ghc::filesystem::path& buildDir,
-                             const runcpp2::Data::ScriptInfo& scriptInfo,
-                             const runcpp2::Data::Profile& currentProfile,
-                             const std::string& scriptName,
-                             bool asExecutable,
-                             ghc::filesystem::path& outOutputPath)
+                            const runcpp2::Data::ScriptInfo& scriptInfo,
+                            const runcpp2::Data::Profile& currentProfile,
+                            const std::string& scriptName,
+                            const bool asExecutable,
+                            ghc::filesystem::path& outOutputPath)
     {
         if(!runcpp2::Data::BuildTypeHelper::GetOutputPath(  buildDir, 
-                                                             scriptName,
-                                                             currentProfile,
-                                                             scriptInfo.CurrentBuildType,
-                                                             asExecutable,
-                                                             outOutputPath))
+                                                            scriptName,
+                                                            currentProfile,
+                                                            scriptInfo.CurrentBuildType,
+                                                            asExecutable,
+                                                            outOutputPath))
         {
             ssLOG_ERROR("Extension or prefix not found in compiler profile for build type: " << 
                         runcpp2::Data::BuildTypeToString(scriptInfo.CurrentBuildType));