Skip to content
This repository was archived by the owner on Dec 17, 2020. It is now read-only.

Commit 2f079b5

Browse files
committed
Fixed onDestory crash.
1 parent 175d092 commit 2f079b5

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

DOCUMENTATION.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,9 +229,15 @@ public class MyBaseActivity extends SomeActivity implements TaskManagerOwner {
229229

230230
@Override
231231
protected void onStop() {
232-
proxy.onStop();
232+
proxy.onStop(); // Call before super!
233233
super.onStop();
234234
}
235+
236+
@Override
237+
protected void onDestroy() {
238+
proxy.onDestroy(); // Call before super!
239+
super.onDestroy();
240+
}
235241

236242
@Override
237243
public TaskManager getTaskManager() {

library/src/main/java/org/neotech/library/retainabletasks/providers/TaskActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ protected void onStop() {
5656

5757
@Override
5858
protected void onDestroy() {
59-
super.onDestroy();
6059
proxy.onDestroy();
60+
super.onDestroy();
6161
}
6262

6363
@Override

library/src/main/java/org/neotech/library/retainabletasks/providers/TaskActivityCompat.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ protected void onStop() {
5151

5252
@Override
5353
protected void onDestroy() {
54-
super.onDestroy();
5554
proxy.onDestroy();
55+
super.onDestroy();
5656
}
5757

5858
@Override

library/src/main/java/org/neotech/library/retainabletasks/providers/TaskFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ public void onStop() {
5757

5858
@Override
5959
public void onDestroy() {
60-
super.onDestroy();
6160
proxy.onDestroy();
61+
super.onDestroy();
6262
}
6363

6464
@Override

library/src/main/java/org/neotech/library/retainabletasks/providers/TaskFragmentCompat.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ public void onStop() {
5353

5454
@Override
5555
public void onDestroy() {
56-
super.onDestroy();
5756
proxy.onDestroy();
57+
super.onDestroy();
5858
}
5959

6060
@Override

0 commit comments

Comments
 (0)