Skip to content
This repository was archived by the owner on Dec 17, 2020. It is now read-only.

Commit ca2b299

Browse files
committed
Tiny JavaDoc improvements.
1 parent ba39d47 commit ca2b299

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

library/src/main/java/org/neotech/library/retainabletasks/TaskManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public interface TaskAttachListener {
4545
*/
4646
@MainThread
4747
public abstract Task<?, ?> getTask(@NonNull String tag);
48-
48+
4949
@MainThread
5050
public abstract Task<?, ?> attach(@NonNull String tag, @NonNull Task.Callback callback);
5151

library/src/main/java/org/neotech/library/retainabletasks/internal/TaskRetainingFragmentCompat.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public void onCreate(Bundle savedInstanceState) {
1919
@Override
2020
public void onStop() {
2121
super.onStop();
22-
//As soon as the activity is stopped the UI should not be touched.
22+
//Is this extra detach needed? Correct usage of the TaskManagerLifeCycleProxy should be enough.
2323
logic.getActivityTaskManager().detach();
2424
logic.assertActivityTasksAreDetached();
2525
}
@@ -29,12 +29,7 @@ public void onDestroy() {
2929
/**
3030
* The activity is destroyed, this method WON'T be called when the fragment is being
3131
* propagated between activity instances.
32-
*
33-
* Cleanup, but let the tasks finish as they might do something important.
34-
* The references to the tasks are lost at this point.
3532
*/
36-
37-
//logic.getActivityTaskManager().detach();
3833
logic.assertFragmentTasksAreDetached();
3934
super.onDestroy();
4035
}

0 commit comments

Comments
 (0)