Skip to content

Commit fb6cbff

Browse files
authored
Feature/android gradle plugin 3.4 (#12)
- Update Gradle to version 5.4.1 - Update Kotlin to version 1.3.40 - Update Android Gradle Plugin to version 3.4.1 - Update AndroidX AppCompat to version 1.0.2 - Update Google Truth to version 0.45 - Update AndroidX Test Runner to version 1.1.1 - Update Espresso Core to version 3.1.1 - Update Apache Commons CSV to version 1.7 - Update target and compile SDK versions to API level 29 (Android Q) - Use `androidx.test.ext.junit.runners.AndroidJUnit4` instead of `androidx.test.runner.AndroidJUnit4` - Added Gradle version 5.4.1 to test fixture
1 parent d5d025f commit fb6cbff

File tree

7 files changed

+19
-15
lines changed

7 files changed

+19
-15
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ https://www.jetbrains.com/help/idea/jetgradle-tool-window.html) or from the term
6060
# Compatibility
6161
| Version | Android Gradle plugin version | Gradle version |
6262
| ------------- | ----------------------------- | -------------- |
63+
| **develop** | 3.4 | 5.1.1+ |
6364
| **1.1.1** | 3.3 | 4.10.1+ |
6465
| ~~**1.1.0**~~ | ~~3.3~~ | ~~5+~~ |
6566
| **1.0.2** | 3.2 | 4.6+ |

gradle/dependencies.gradle

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,27 @@
11
ext {
22
projectVersion = [
33
minSdk : 19,
4-
targetSdk : 28,
5-
compileSdk: 28,
6-
kotlin : "1.3.30"
4+
targetSdk : 29,
5+
compileSdk: 29,
6+
kotlin : "1.3.40"
77
]
88
projectDependency = [
99

1010
// Gradle Plugins
1111
kotlinPlugin : "org.jetbrains.kotlin:kotlin-gradle-plugin:${projectVersion.kotlin}",
12-
androidGradlePlugin: "com.android.tools.build:gradle:3.3.0",
12+
androidGradlePlugin: "com.android.tools.build:gradle:3.4.1",
1313

1414
// Dependencies
1515
kotlinStdlibJdk7 : "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${projectVersion.kotlin}",
16-
appCompat : "androidx.appcompat:appcompat:1.0.0",
16+
appCompat : "androidx.appcompat:appcompat:1.0.2",
1717

1818
// Test dependencies
1919
junit : "junit:junit:4.12",
20-
truth : "com.google.truth:truth:0.44",
21-
supportTestRunner : "androidx.test:runner:1.1.0",
22-
espressoCore : "androidx.test.espresso:espresso-core:3.1.0",
23-
commonsCsv : "org.apache.commons:commons-csv:1.6",
20+
truth : "com.google.truth:truth:0.45",
21+
supportTestRunner : "androidx.test:runner:1.1.1",
22+
espressoCore : "androidx.test.espresso:espresso-core:3.1.1",
23+
androidJUnit : "androidx.test.ext:junit:1.1.0",
24+
commonsCsv : "org.apache.commons:commons-csv:1.7",
2425
kotlinTest : "org.jetbrains.kotlin:kotlin-test:${projectVersion.kotlin}"
2526
]
2627

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Tue Jan 22 16:40:52 CET 2019
1+
#Thu Apr 25 15:55:50 CEST 2019
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-5.1.1-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip

plugin/src/test/kotlin/org/neotech/plugin/rootcoverage/IntegrationTest.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ class IntegrationTest(
5151
@JvmStatic
5252
fun parameters(): List<Array<Any>> {
5353

54-
val testFixtures = File("src/test/test-fixtures").listFiles().filter { it.isDirectory }
55-
val gradleVersions = arrayOf("4.10.1", "5.1.1")
54+
val testFixtures = File("src/test/test-fixtures").listFiles()?.filter { it.isDirectory }
55+
?: error("Could not list test fixture directories")
56+
val gradleVersions = arrayOf("5.1.1", "5.2.1", "5.4.1")
5657

5758
return testFixtures.flatMap { file ->
5859
gradleVersions.map { gradleVersion ->

plugin/src/test/test-fixtures/multi-module/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ android {
3333
}
3434

3535
dependencies {
36-
3736
implementation project(":library_android")
3837

3938
implementation projectDependency.kotlinStdlibJdk7
@@ -42,4 +41,5 @@ dependencies {
4241
testImplementation projectDependency.junit
4342
androidTestImplementation projectDependency.supportTestRunner
4443
androidTestImplementation projectDependency.espressoCore
44+
androidTestImplementation projectDependency.androidJUnit
4545
}

plugin/src/test/test-fixtures/multi-module/app/src/androidTest/java/org/neotech/app/multimoduleapplication/TouchLibraryCodeTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.neotech.app.multimoduleapplication
22

3-
import androidx.test.runner.AndroidJUnit4
3+
import androidx.test.ext.junit.runners.AndroidJUnit4
44

55
import org.junit.Test
66
import org.junit.runner.RunWith

plugin/src/test/test-fixtures/multi-module/library_android/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,5 @@ dependencies {
4444
testImplementation projectDependency.junit
4545
androidTestImplementation projectDependency.supportTestRunner
4646
androidTestImplementation projectDependency.espressoCore
47+
androidTestImplementation projectDependency.androidJUnit
4748
}

0 commit comments

Comments
 (0)