Skip to content

Commit 1f8ce5b

Browse files
authored
Improve typing in cookies module (#639)
1 parent 2645817 commit 1f8ce5b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

blacksheep/cookies.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,21 +57,21 @@ def __init__(
5757
self.same_site = same_site
5858

5959
@property
60-
def name(self):
60+
def name(self) -> str:
6161
return self._name
6262

6363
@name.setter
64-
def name(self, value):
64+
def name(self, value: str):
6565
if not value:
6666
raise ValueError("A cookie name is required")
6767
self._name = value
6868

6969
@property
70-
def value(self):
70+
def value(self) -> str:
7171
return self._value
7272

7373
@value.setter
74-
def value(self, value):
74+
def value(self, value: str):
7575
if value and len(value.encode()) > 4096:
7676
raise CookieValueExceedsMaximumLength()
7777
self._value = value
@@ -98,11 +98,11 @@ def __eq__(self, other):
9898
return other.name == self.name and other.value == self.value
9999
return NotImplemented
100100

101-
def __repr__(self):
101+
def __repr__(self) -> str:
102102
return f"<Cookie {self.name}: {self.value}>"
103103

104104

105-
def split_value(raw_value: bytes, separator: bytes):
105+
def split_value(raw_value: bytes, separator: bytes) -> tuple[bytes, bytes]:
106106
try:
107107
index = raw_value.index(separator)
108108
except ValueError:
@@ -111,7 +111,7 @@ def split_value(raw_value: bytes, separator: bytes):
111111
return raw_value[:index], raw_value[index + 1 :]
112112

113113

114-
def same_site_mode_from_bytes(raw_value: bytes) -> CookieSameSiteMode:
114+
def same_site_mode_from_bytes(raw_value: bytes | None) -> CookieSameSiteMode:
115115
if not raw_value:
116116
return CookieSameSiteMode.UNDEFINED
117117
raw_value_lower = raw_value.lower()
@@ -132,7 +132,7 @@ def parse_cookie(raw_value: bytes) -> Cookie:
132132
try:
133133
name, value = split_value(raw_value, eq)
134134
except ValueError:
135-
raise ValueError(f"Invalid name=value fragment: {parts[0]}")
135+
raise ValueError(f"Invalid name=value fragment: {parts[0]!r}")
136136
else:
137137
return Cookie(name.decode(), value.decode())
138138
if len(parts) == 1:
@@ -141,7 +141,7 @@ def parse_cookie(raw_value: bytes) -> Cookie:
141141
try:
142142
name, value = split_value(parts[0], eq)
143143
except ValueError:
144-
raise ValueError(f"Invalid name=value fragment: {parts[0]}")
144+
raise ValueError(f"Invalid name=value fragment: {parts[0]!r}")
145145
if b" " in value and value.startswith(b'"'):
146146
value = value.strip(b'"')
147147
expires = None

0 commit comments

Comments
 (0)