FromFiles doesn't affect openapi spec (availble workagounds)

[tyzhnenko]

I found that BlackSheep can't generate proper OAS for a multi-part body if a handler uses BodyBinder via FromFiles type binder.

app = Application()

docs = OpenAPIHandler(info=Info(title="Example API", version="0.0.1"))
docs.bind_app(app)

@app.router.post("/images")
async def upload_image(images: FromFiles): ...

I've expected to have something like this.

This can't be solved by changing the parent of FilesBinder to BodyBinder because FilesBinder will conflict with FromFromBinder when they are used together. BlackSheep allows to have only one body binder for a handler.

I found the only way to see the file upload button in UI is to use the Pydantic model with the bytes field.

class FileInput(BaseModel):
    files: bytes


@app.router.post("/images")
async def upload_image(images: FromForm[FileInput]): ...

There is a solution for objects like dataclasses and Pytdantic models to see multi-file upload. OpenAPIHandler should resolve a schema for bytes simple type in _try_get_schema_for_simple_type method.

<skip>
        if object_type is bytes:
            return Schema(type=ValueType.STRING, format=ValueFormat.BINARY)
<skip>

Then, those classes will look like in the image below.

class FileInput(BaseModel):
    files: List[bytes]


@dataclass(init=False)
class OtherInput:
    files: List[bytes]

Have I missed something? Any other workarounds?

[tyzhnenko]

I've prepared a PR with bytes handling #506