Working on Speleothem tests

The Speleothem endpoint was added, but needed some minor tweaks to make it pass the tests.

First, I added a new 'collectionunitidPath` to the openapi parameters. This allows us to test the endpoint properly.

To support collectionunitids or other parameters elsewhere, I used the `paramgrab` model in the speleothems.js file, along with `ifUndef()`.

This then captures the parameter in the path and passes it along cleanly to the query. The function seems to resolve now.

Author: SimonGoring

openapi.yaml

@@ -180,6 +180,21 @@ components:
         format: int64
         type: integer
         minimum: 0
+        maximum: 70000
+        exclusiveMinimum: true
+    collectionunitidPath:
+      description: >-
+        A valid collection unit identifer from the Neotoma database. This is the internal identifier within the
+        [`ndb.collectionunits`](https://open.neotomadb.org/dbschema/ndb/tables/collectionunits.html) table. If the
+        collection unit ID contains no speleothem data, then the result will be an empty dataset.
+      in: path
+      name: collectionunitid
+      required: true
+      schema:
+        format: int64
+        type: integer
+        minimum: 0
+        maximum: 70000
         exclusiveMinimum: true
     chronidPath:
       description: >-
@@ -3159,7 +3174,7 @@ paths:
     get:
       description: Returns information about speleothem specific metadata given a collectionunit ID.
       parameters:
-        - $ref: '#/components/parameters/collectionunitidQuery'
+        - $ref: '#/components/parameters/collectionunitidPath'
       responses:
         '200':
           content:

openapi/components/parameters/parameters.yml

@@ -130,6 +130,20 @@ collectionunitidQuery:
     format: int64
     type: integer
     minimum: 0
+    maximum: 70000
+    exclusiveMinimum: true
+collectionunitidPath:
+  description: A valid collection unit identifer from the Neotoma database. This is the internal identifier within the 
+    [`ndb.collectionunits`](https://open.neotomadb.org/dbschema/ndb/tables/collectionunits.html) table. If the collection unit ID contains no
+    speleothem data, then the result will be an empty dataset.
+  in: path
+  name: collectionunitid
+  required: true
+  schema:
+    format: int64
+    type: integer
+    minimum: 0
+    maximum: 70000
     exclusiveMinimum: true
 chronidPath:
   description: Unique chronology identifier. This is the internal identifier within the [`ndb.chronologies`](https://open.neotomadb.org/dbschema/ndb/tables/chronologies.html) table. Note that although the chronology IDs are generated sequentially, not all chronology IDs are currently in use.

openapi/paths/v20/data.yml

@@ -187,7 +187,7 @@
   get:
     description: Returns information about speleothem specific metadata given a collectionunit ID.
     parameters:
-      - $ref: '#/components/parameters/collectionunitidQuery'
+      - $ref: '#/components/parameters/collectionunitidPath'
     responses:
       '200':
         content:

public/tests.html

@@ -7,7 +7,7 @@ const expect = chakram.expect;
 describe('tests for /v1.5/data/contacts/{contactid}', function() {
   describe('tests for get', function() {
     it('should respond 200 for "Contact"', function() {
-      const response = request('get', 'http://localhost:3001/v1.5/data/contacts/500', {
+      const response = request('get', 'http://localhost:3001/v1.5/data/contacts/-44938686', {
         'time': true,
       });
 

public/tests.json

@@ -8,7 +8,7 @@ describe('tests for /v1.5/data/geopoliticalunits', function() {
   describe('tests for get', function() {
     it('should respond 200 for "An array of geopolitical units."', function() {
       const response = request('get', 'http://localhost:3001/v1.5/data/geopoliticalunits', {
-        'qs': {'gpid': 5392, 'gpname': 'Canada', 'rank': 2, 'lower': false},
+        'qs': {'gpid': 5392, 'gpname': 'Canada', 'rank': 4, 'lower': true},
         'time': true,
       });
 

test/v1.5-data-contacts-{contactid}-test.js

@@ -7,7 +7,7 @@ const expect = chakram.expect;
 describe('tests for /v1.5/data/geopoliticalunits/{gpid}', function() {
   describe('tests for get', function() {
     it('should respond 200 for "An array of geopolitical units."', function() {
-      const response = request('get', 'http://localhost:3001/v1.5/data/geopoliticalunits/500', {
+      const response = request('get', 'http://localhost:3001/v1.5/data/geopoliticalunits/6244', {
         'time': true,
       });
 

test/v1.5-data-geopoliticalunits-test.js

@@ -8,7 +8,7 @@ describe('tests for /v2.0/apps/constdb/datasetages', function() {
   describe('tests for get', function() {
     it('should respond 200 for "Returns an ordered array (from earliest to latest) of upload counts by month (YYYY/MM/DD; all days as 01). Months with no uploads are excluded. "', function() {
       const response = request('get', 'http://localhost:3001/v2.0/apps/constdb/datasetages', {
-        'qs': {'dbid': 3},
+        'qs': {'dbid': 14},
         'time': true,
       });
 

test/v1.5-data-geopoliticalunits-{gpid}-test.js

@@ -8,7 +8,7 @@ describe('tests for /v2.0/apps/constdb/datasets', function() {
   describe('tests for get', function() {
     it('should respond 200 for "Returns the set of datasets contained within a constituent database, identified by the constituent database identifier. Used for quick landing page generation. "', function() {
       const response = request('get', 'http://localhost:3001/v2.0/apps/constdb/datasets', {
-        'qs': {'dbid': 27},
+        'qs': {'dbid': 9},
         'time': true,
       });