Skip to content

Commit f4ed58a

Browse files
committed
Improve some comments
1 parent 91a2bd4 commit f4ed58a

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

neotron-bmc-pico/src/main.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,8 @@ mod app {
471471
ctx.shared.pin_sys_reset.lock(|pin| pin.set_low().unwrap());
472472
// Step 4 - Turn on PSU
473473
ctx.shared.pin_dc_on.set_high().unwrap();
474-
// Step 5 happens below when power is good
474+
// Taking the system out of reset and enabling the IRQ line happens
475+
// later, when the power rail is settled
475476
defmt::info!("Waiting for power-good");
476477
}
477478
}
@@ -590,7 +591,7 @@ mod app {
590591
}
591592
// TODO: Also monitor 5.0V rail
592593

593-
// Wait for power good
594+
// Wait for power-good
594595
if ctx.shared.state_dc_power_enabled.lock(|r| *r) == DcPowerState::Starting {
595596
let mon_3v3 = ctx.local.adc.read_abs_mv(ctx.local.pin_3v3_monitor);
596597
defmt::trace!("3v3 reading: {}", mon_3v3);
@@ -607,13 +608,10 @@ mod app {
607608
ctx.shared
608609
.state_dc_power_enabled
609610
.lock(|r| *r = DcPowerState::On);
610-
// Steps 1 - 4 happened above, in the button press handler
611-
// Step 5 - Leave it in reset for a while.
612-
// TODO: Start monitoring 3.3V and 5.0V rails here
613-
// TODO: Take system out of reset when 3.3V and 5.0V are good
611+
// Wait a bit before taking system out of reset.
614612
// Returns an error if it's already scheduled (but we don't care)
615613
let _ = exit_reset::spawn_after(RESET_DURATION_MS.millis());
616-
// Set 6 - unmask the IRQ
614+
// Unmask the IRQ
617615
irq_forced_low = false;
618616
}
619617
}

0 commit comments

Comments
 (0)