embedded-sdmmc updates.

Author: thejpster

Cargo.lock

@@ -49,7 +49,7 @@ postcard = "1.0"
 serde = { version = "1.0", default-features = false }
 menu = "0.3"
 chrono = { version = "0.4", default-features = false }
-embedded-sdmmc = { version = "0.5", default-features = false }
+embedded-sdmmc = { git = "https://github.com/rust-embedded-community/embedded-sdmmc-rs", default-features = false }
 neotron-api = "0.1"
 neotron-loader = "0.1"
 vte = "0.12"

Cargo.toml

@@ -33,11 +33,11 @@ fn dir(_menu: &menu::Menu<Ctx>, _item: &menu::Item<Ctx>, _args: &[&str], _ctx: &
         let time = crate::fs::BiosTime();
         let mut mgr = embedded_sdmmc::VolumeManager::new(bios_block, time);
         // Open the first partition
-        let volume = mgr.get_volume(VolumeIdx(0))?;
-        let root_dir = mgr.open_root_dir(&volume)?;
+        let volume = mgr.open_volume(VolumeIdx(0))?;
+        let root_dir = mgr.open_root_dir(volume)?;
         let mut total_bytes = 0u64;
         let mut num_files = 0;
-        mgr.iterate_dir(&volume, &root_dir, |dir_entry| {
+        mgr.iterate_dir(root_dir, |dir_entry| {
             let padding = 8 - dir_entry.name.base_name().len();
             for b in dir_entry.name.base_name() {
                 let ch = *b as char;

src/commands/fs.rs

@@ -127,14 +127,9 @@ fn play(_menu: &menu::Menu<Ctx>, _item: &menu::Item<Ctx>, args: &[&str], ctx: &m
         let time = crate::fs::BiosTime();
         let mut mgr = embedded_sdmmc::VolumeManager::new(bios_block, time);
         // Open the first partition
-        let mut volume = mgr.get_volume(embedded_sdmmc::VolumeIdx(0))?;
-        let root_dir = mgr.open_root_dir(&volume)?;
-        let mut file = mgr.open_file_in_dir(
-            &mut volume,
-            &root_dir,
-            file_name,
-            embedded_sdmmc::Mode::ReadOnly,
-        )?;
+        let volume = mgr.open_volume(embedded_sdmmc::VolumeIdx(0))?;
+        let root_dir = mgr.open_root_dir(volume)?;
+        let file = mgr.open_file_in_dir(root_dir, file_name, embedded_sdmmc::Mode::ReadOnly)?;
 
         osprintln!("Press Q to quit, P to pause/unpause...");
 
@@ -145,9 +140,10 @@ fn play(_menu: &menu::Menu<Ctx>, _item: &menu::Item<Ctx>, args: &[&str], ctx: &m
         let mut delta = 0;
 
         let mut pause = false;
-        'playback: while !file.eof() {
+
+        'playback: while !mgr.file_eof(file).unwrap() {
             if !pause {
-                let bytes_read = mgr.read(&volume, &mut file, buffer)?;
+                let bytes_read = mgr.read(file, buffer)?;
                 let mut buffer = &buffer[0..bytes_read];
                 while !buffer.is_empty() {
                     let slice = bios::FfiByteSlice::new(buffer);

src/commands/sound.rs

@@ -61,24 +61,18 @@ impl From<neotron_loader::Error<embedded_sdmmc::Error<bios::Error>>> for Error {
 /// Something the ELF loader can use to get bytes off the disk
 struct FileSource {
     mgr: core::cell::RefCell<embedded_sdmmc::VolumeManager<BiosBlock, BiosTime>>,
-    volume: embedded_sdmmc::Volume,
-    file: core::cell::RefCell<File>,
+    file: embedded_sdmmc::File,
     buffer: core::cell::RefCell<[u8; Self::BUFFER_LEN]>,
     offset_cached: core::cell::Cell<Option<u32>>,
 }
 
 impl FileSource {
     const BUFFER_LEN: usize = 128;
 
-    fn new(
-        mgr: embedded_sdmmc::VolumeManager<BiosBlock, BiosTime>,
-        volume: embedded_sdmmc::Volume,
-        file: File,
-    ) -> FileSource {
+    fn new(mgr: embedded_sdmmc::VolumeManager<BiosBlock, BiosTime>, file: File) -> FileSource {
         FileSource {
             mgr: core::cell::RefCell::new(mgr),
-            file: core::cell::RefCell::new(file),
-            volume,
+            file,
             buffer: core::cell::RefCell::new([0u8; 128]),
             offset_cached: core::cell::Cell::new(None),
         }
@@ -90,10 +84,11 @@ impl FileSource {
         out_buffer: &mut [u8],
     ) -> Result<(), embedded_sdmmc::Error<bios::Error>> {
         osprintln!("Reading from {}", offset);
-        self.file.borrow_mut().seek_from_start(offset).unwrap();
         self.mgr
             .borrow_mut()
-            .read(&self.volume, &mut self.file.borrow_mut(), out_buffer)?;
+            .file_seek_from_start(self.file, offset)
+            .unwrap();
+        self.mgr.borrow_mut().read(self.file, out_buffer)?;
         Ok(())
     }
 }
@@ -117,12 +112,13 @@ impl neotron_loader::traits::Source for &FileSource {
             }
 
             osprintln!("Reading from {}", offset);
-            self.file.borrow_mut().seek_from_start(offset).unwrap();
-            self.mgr.borrow_mut().read(
-                &self.volume,
-                &mut self.file.borrow_mut(),
-                self.buffer.borrow_mut().as_mut_slice(),
-            )?;
+            self.mgr
+                .borrow_mut()
+                .file_seek_from_start(self.file, offset)
+                .unwrap();
+            self.mgr
+                .borrow_mut()
+                .read(self.file, self.buffer.borrow_mut().as_mut_slice())?;
             self.offset_cached.set(Some(offset));
             chunk.copy_from_slice(&self.buffer.borrow()[0..chunk.len()]);
 
@@ -209,16 +205,11 @@ impl TransientProgramArea {
         let time = crate::fs::BiosTime();
         let mut mgr = embedded_sdmmc::VolumeManager::new(bios_block, time);
         // Open the first partition
-        let mut volume = mgr.get_volume(embedded_sdmmc::VolumeIdx(0))?;
-        let root_dir = mgr.open_root_dir(&volume)?;
-        let file = mgr.open_file_in_dir(
-            &mut volume,
-            &root_dir,
-            file_name,
-            embedded_sdmmc::Mode::ReadOnly,
-        )?;
-
-        let source = FileSource::new(mgr, volume, file);
+        let volume = mgr.open_volume(embedded_sdmmc::VolumeIdx(0))?;
+        let root_dir = mgr.open_root_dir(volume)?;
+        let file = mgr.open_file_in_dir(root_dir, file_name, embedded_sdmmc::Mode::ReadOnly)?;
+
+        let source = FileSource::new(mgr, file);
         let loader = neotron_loader::Loader::new(&source)?;
 
         let mut iter = loader.iter_program_headers();