Skip to content

Commit 2f5d2bf

Browse files
authored
Merge pull request #73 from Neotron-Compute/update-protocol-crate
Update to published BMC crates.
2 parents 10f873e + f9c6625 commit 2f5d2bf

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

Cargo.lock

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,9 @@ pio-proc = "0.2"
3737
# Hardware locks for sharing data with interrupts
3838
critical-section = "1.0"
3939
# Commands for talking to a Neotron BMC. The tag is for the repo as a whole, of which the commands crate is a small part.
40-
neotron-bmc-commands = { version = "0.1.0", git = "https://github.com/neotron-compute/neotron-bmc", tag = "v0.5.2" }
40+
neotron-bmc-commands = { version = "0.2.0" }
4141
# Protocol for talking to a Neotron BMC. The tag is for the repo as a whole, of which the protocol crate is a small part.
42-
neotron-bmc-protocol = { version = "0.1.0", git = "https://github.com/neotron-compute/neotron-bmc", tag = "v0.5.2", features = [
43-
"defmt"
44-
] }
42+
neotron-bmc-protocol = { version = "0.1.0", features = ["defmt"] }
4543
# Time and frequency related functions
4644
fugit = "0.3"
4745
# PS/2 scancode decoding

src/main.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,18 +1173,14 @@ impl Hardware {
11731173
fn play_startup_tune(&mut self) -> Result<(), ()> {
11741174
// (delay (ms), command, data)
11751175
let seq: &[(u16, Command, u8)] = &[
1176-
// NB: Due to a BMC bug, this sets the high period
11771176
(0, Command::SpeakerPeriodLow, 137),
1178-
// NB: Due to a BMC bug, this sets the low period
11791177
(0, Command::SpeakerPeriodHigh, 0),
11801178
(0, Command::SpeakerDutyCycle, 127),
11811179
// This triggers the beep to occur
11821180
(70, Command::SpeakerDuration, 7),
1183-
// NB: Due to a BMC bug, this sets the high period
11841181
(0, Command::SpeakerPeriodLow, 116),
11851182
// This triggers the beep to occur
11861183
(70, Command::SpeakerDuration, 7),
1187-
// NB: Due to a BMC bug, this sets the high period
11881184
(0, Command::SpeakerPeriodLow, 97),
11891185
// This triggers the beep to occur
11901186
(70, Command::SpeakerDuration, 7),

0 commit comments

Comments
 (0)