Clean up some clippy lints

Author: thejpster

src/console.rs

@@ -93,7 +93,7 @@ where
     if let Some(value) = iter.next() {
         let _ = write!(f, "{}", value as u8);
     }
-    while let Some(value) = iter.next() {
+    for value in iter {
         let _ = write!(f, ";{}", value as u8);
     }
     let _ = write!(f, "m");

src/fake_os_api.rs

@@ -105,7 +105,7 @@ extern "C" fn api_read(
     mut buffer: neotron_api::FfiBuffer,
 ) -> neotron_api::Result<usize> {
     if fd == neotron_api::file::Handle::new_stdin() {
-        if let Some(b) = STDIN_RX.lock().unwrap().as_mut().unwrap().try_recv().ok() {
+        if let Ok(b) = STDIN_RX.lock().unwrap().as_mut().unwrap().try_recv() {
             buffer.as_mut_slice().unwrap()[0] = b;
             neotron_api::Result::Ok(1)
         } else {

src/lib.rs

@@ -343,7 +343,7 @@ pub fn srand(seed: u16) {
 /// Get a 16-bit psuedorandom number
 pub fn rand() -> u16 {
     let mut state = RAND_STATE.load(core::sync::atomic::Ordering::Relaxed);
-    let bit = ((state >> 0) ^ (state >> 2) ^ (state >> 3) ^ (state >> 5)) & 0x01;
+    let bit = (state ^ (state >> 2) ^ (state >> 3) ^ (state >> 5)) & 0x01;
     state = (state >> 1) | (bit << 15);
     RAND_STATE.store(state, core::sync::atomic::Ordering::Relaxed);
     state