why does it panic instead of returning an `Option`?

[skaunov]

neptune-core/neptune-core/src/application/database/storage/storage_schema/dbtvec_private.rs

Line 50 in 313932d

assert!(

[KaffinPX]

This doesnt seem like a real issue, probably better to just ask over DMs.

[skaunov]

It's an action item. It needs either an argument to be added there, either development to replace it for `Option`.

…

On Сб, дек 13 2025 at 10:25:08 -0800, KaffinPX ***@***.***> wrote: *KaffinPX* left a comment (Neptune-Crypto/neptune-core#816) <#816 (comment)> This doesnt seem like a real issue, probably better to just ask over DMs. — Reply to this email directly, view it on GitHub <#816 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APXLOT5JAF4J5PM22K5KD4D4BRKYJAVCNFSM6AAAAACO6FLRK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNBZGY4DONZVHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[KaffinPX]

Im saying you are shadowing more important issues with dumb code quality-related critiques

[skaunov]

What exactly am I shadowing? :puzzled: It's just an item to be fixed. 🤷 Are you ok? I worry a bit about you now; though maybe I just confused something. =(

[aszepieniec]

This should be debug_assert! instead of assert!. We do not actually want to spend cycles on this assert in production. However, we do want to spend those cycles in tests so we can return useful information to the user in case their logic is wrong.