Made them handle a failure message from AWS better.

Author: kcantrel

Management-Utilities/fsx-ontap-aws-cli-scripts/create_fsxn_filesystem

@@ -180,7 +180,12 @@ else
           fi
           if [ "$status" != "CREATING" -a "$status" != "PENDING" ]; then
             printf "\nError, failed to create the file system. Status = $status\n" 1>&2
-            cat $tmpout 1>&2
+            reason="$(jq -r '.FileSystems[0].LifecycleTransitionReason.Message' $tmpout 2> /dev/null)"
+            if [ ! -z "$reason" ]; then
+              echo "Reason: $reason" 1>&2
+            else
+              cat $tmpout 1>&2
+            fi
             exit 1
           fi
           printf "."

Management-Utilities/fsx-ontap-aws-cli-scripts/create_fsxn_svm

@@ -116,7 +116,12 @@ else
           fi
           if [ "$status" != "CREATING" -a "$status" != "PENDING" ]; then
             printf "\nError, failed to create SVM with SVM ID '$svmId'. Status = $status\n" 1>&2
-            cat $tmpout 1>&2
+            reason="$(jq -r '.StorageVirtualMachines[0].LifecycleTransitionReason.Message' $tmpout)"
+            if [ ! -z "$reason" ]; then
+              echo "Reason: $reason" 1>&2
+            else
+              cat $tmpout 1>&2
+            fi
             exit 1
           fi
         else

Management-Utilities/fsx-ontap-aws-cli-scripts/create_fsxn_volume

@@ -105,7 +105,12 @@ else
         fi
         if [ $status != "CREATING" -a $status != "PENDING" ]; then
           echo "Error, volume $volumeId creation failed." 1>&2
-          cat $tmpout 1>&2
+          reason="$(jq -r '.Volumes[0].LifecycleTransitionReason.Message' $tmpout 2> /dev/null)"
+          if [ -n "$reason" ]; then
+            echo "Reason: $reason" 1>&2
+          else
+            cat $tmpout 1>&2
+          fi
           exit 1
         fi
         echo -n "."

Management-Utilities/fsx-ontap-aws-cli-scripts/delete_fsxn_filesystem

@@ -213,7 +213,12 @@ else
           status=$(jq -r '.FileSystems[0].Lifecycle' $tmpout 2> /dev/null)
           if [ "$status" != "DELETING" -a "$status" != "PENDING" ]; then
             printf "\nError, failed to delete file system with file system ID '$fsid'. Status = $status\n" 1>&2
-            cat $tmpout 1>&2
+            reason="$(jq -r '.FileSystems[0].LifecycleTransitionReason.Message' $tmpout 2> /dev/null)"
+            if [ ! -z "$reason" ]; then
+              printf "Reason: $reason\n" 1>&2
+            else
+              cat $tmpout 1>&2
+            fi
             exit 1
           else
             printf "."

Management-Utilities/fsx-ontap-aws-cli-scripts/delete_fsxn_svm

@@ -209,7 +209,12 @@ else
           status=$(jq -r '.StorageVirtualMachines[0].Lifecycle' $tmpout 2> /dev/null)
           if [ "$status" != "DELETING" -a "$status" != "PENDING" ]; then
             printf "\nError, failed to delete SVM with SVM ID '$svmID'. Status = $status\n" 1>&2
-            cat $tmpout 1>&2
+            reason="$(jq -r '.StorageVirtualMachines[0].LifecycleTransitionReason.Message' $tmpout 2> /dev/null)"
+            if [ ! -z "$reason" ]; then
+              echo "Reason: $reason" 1>&2
+            else
+              cat $tmpout 1>&2
+            fi
             exit 1
           else
             printf "."

Management-Utilities/fsx-ontap-aws-cli-scripts/delete_fsxn_volume

@@ -47,7 +47,12 @@ waitForVolumeDelete () {
       status=$(jq -r .Volumes[0].Lifecycle $tmpout 2> /dev/null)
       if [ "$status" != "DELETING" -a "$status" != "PENDING" ]; then
         printf "\nError, failed to delete volume with volume ID '$volumeId'. Status = ${status}.\n" 1>&2
-        cat $tmpout 1>&2
+        reason="$(jq -r '.Volumes[0].LifecycleTransitionReason.Message' $tmpout 2> /dev/null)"
+        if [ ! -z "$reason" ]; then
+          echo "Reason: $reason" 1>&2
+        else
+          cat $tmpout 1>&2
+        fi
         return 1
       fi
     else