Skip to content

Commit 873f0bb

Browse files
authored
Merge branch 'main' into add_monitor_fsxn_with_arvest
2 parents 779dced + 4b18d12 commit 873f0bb

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

EKS/FSxN-as-PVC-for-EKS/terraform/fsx.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module "fsxn_rotate_secret" {
44
source = "github.com/Netapp/FSx-ONTAP-samples-scripts/Management-Utilities/fsxn-rotate-secret/terraform"
55
fsx_region = var.aws_region
66
secret_region = var.aws_secrets_region
7-
aws_account_id = var.aws_account_id
7+
aws_account_id = data.aws_caller_identity.current.account_id
88
secret_name_prefix = var.secret_name_prefix
99
fsx_id = aws_fsx_ontap_file_system.eksfs.id
1010
}
@@ -28,7 +28,7 @@ module "svm_rotate_secret" {
2828
source = "github.com/Netapp/FSx-ONTAP-samples-scripts/Management-Utilities/fsxn-rotate-secret/terraform"
2929
fsx_region = var.aws_region
3030
secret_region = var.aws_secrets_region
31-
aws_account_id = var.aws_account_id
31+
aws_account_id = data.aws_caller_identity.current.account_id
3232
secret_name_prefix = var.secret_name_prefix
3333
svm_id = aws_fsx_ontap_storage_virtual_machine.ekssvm.id
3434
}

EKS/FSxN-as-PVC-for-EKS/terraform/variables.tf

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,13 @@
11
variable "aws_region" {
22
description = "The AWS region where you want the resources deployed."
33
type = string
4+
default = "us-west-2"
45
}
56

67
variable "aws_secrets_region" {
78
description = "The AWS region where you want the FSxN and SVM secrets stored within AWS Secrets Manager."
89
type = string
9-
}
10-
11-
variable "aws_account_id" {
12-
description = "The AWS account ID. Used to create very specific permissions in the IAM role for the EKS cluster."
13-
type = string
10+
default = "us-west-2"
1411
}
1512

1613
variable "fsx_name" {
@@ -36,9 +33,9 @@ variable "fsxn_storage_capacity" {
3633
variable "fsxn_throughput_capacity" {
3734
description = "The throughput capacity to be allocated to the FSxN cluster. Must be 128, 256, 512, 1024, 2048, 4096."
3835
type = string # Set to a string so it can be used in a "contains()" function.
39-
default = 128
36+
default = "128"
4037
validation {
41-
condition = contains([128, 256, 512, 1024, 2048, 4096], var.fsxn_throughput_capacity)
38+
condition = contains(["128", "256", "512", "1024", "2048", "4096"], var.fsxn_throughput_capacity)
4239
error_message = "The throughput capacity must be 128, 256, 512, 1024, 2048, or 4096."
4340
}
4441
}

Management-Utilities/fsxn-rotate-secret/fsxn_rotate_secret.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import os
1313
import json
1414

15-
charactersToExcludeInPassword = '/"\'\\'
15+
charactersToExcludeInPassword = '/"*\'\\'
1616

1717
################################################################################
1818
# This function is used to get the value of a tag from a list of tags.

0 commit comments

Comments
 (0)