Skip to content

Commit bde4f72

Browse files
authored
Merge branch 'main' into add_cf_ext_samples
2 parents 4636e66 + 0d08894 commit bde4f72

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

Monitoring/auto-add-cw-alarms/auto_add_cw_alarms.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -556,9 +556,9 @@ def usage():
556556
dryRun = False
557557
#
558558
# Check to see if there any any environment variables set.
559-
customerId = os.environ.get('customerId', '')
560-
accountId = os.environ.get('accountId', '')
561-
SNStopic = os.environ.get('SNStopic', '')
559+
customerId = os.environ.get('customerId', customerId)
560+
accountId = os.environ.get('accountId', accountId)
561+
SNStopic = os.environ.get('SNStopic', SNStopic)
562562
onlyFilesystemId = None
563563
defaultCPUThreshold = int(os.environ.get('defaultCPUThreshold', defaultCPUThreshold))
564564
defaultSSDThreshold = int(os.environ.get('defaultSSDThreshold', defaultSSDThreshold))

Monitoring/auto-add-cw-alarms/cloudformation.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ Resources:
190190
# Lastly, you can create an override for the SSD alarm, by creating a tag
191191
# with the name "SSD_Alarm_Threshold" on the file system resource.
192192
#
193-
# Version: v2.13
194-
# Date: 2024-10-03-12:30:21
193+
# Version: v2.1
194+
# Date: 2025-01-31-20:33:33
195195
#
196196
################################################################################
197197
#
@@ -719,9 +719,9 @@ Resources:
719719
dryRun = False
720720
#
721721
# Check to see if there any any environment variables set.
722-
customerId = os.environ.get('customerId', '')
723-
accountId = os.environ.get('accountId', '')
724-
SNStopic = os.environ.get('SNStopic', '')
722+
customerId = os.environ.get('customerId', customerId)
723+
accountId = os.environ.get('accountId', accountId)
724+
SNStopic = os.environ.get('SNStopic', SNStopic)
725725
onlyFilesystemId = None
726726
defaultCPUThreshold = int(os.environ.get('defaultCPUThreshold', defaultCPUThreshold))
727727
defaultSSDThreshold = int(os.environ.get('defaultSSDThreshold', defaultSSDThreshold))

Monitoring/monitor-ontap-services/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ To install the program using the CloudFormation template, you will need to do th
5454

5555
|Parameter Name | Notes|
5656
|---|---|
57-
|Stackname|The name you want to assign to the CloudFormation stack. Note that this name is used as a base name for the resources it creates, so please keep it under 25 characters.|
57+
|Stackname|The name you want to assign to the CloudFormation stack. Note that this name is used as a base name for the resources it creates, so please keep it **under 25 characters**. Also, since it is used as part of the s3 bucket name that it creates to keep event information in, it **must be in all lower case letters**.|
5858
|OntapAdminServer|The DNS name, or IP address, of the management endpoint of the FSxN file system you wish to monitor.|
5959
|SubnetIds|The subnet IDs that the Lambda function will be attached to. Must have connectivity to the FSxN file system you wish to monitor.|
6060
|SecurityGroupIds|The security group IDs that the Lambda function will be attached to. The security group most allow outbound traffic over port 443 to the SNS, Secrets Manager and S3 endpoints, as well as the FSxN file system you want to monitor.|

0 commit comments

Comments
 (0)