CSTACKEX-46 Testing: Resolve fetch Storage details issue

Author: Gupta, Surya

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java

@@ -270,7 +270,7 @@ public boolean attachCluster(DataStore dataStore, ClusterScope scope) {
         // TODO- need to check if no host to connect then throw exception or just continue
         logger.debug("attachCluster: Eligible Up and Enabled hosts: {} in cluster {}", hostsToConnect, primaryStore.getClusterId());
 
-        Map<String, String> details = primaryStore.getDetails();
+        Map<String, String> details = storagePoolDetailsDao.listDetailsKeyPairs(storagePool.getId());
         StorageStrategy strategy = Utility.getStrategyByStoragePoolDetails(details);
         ProtocolType protocol = ProtocolType.valueOf(details.get(Constants.PROTOCOL));
         //TODO- Check if we have to handle heterogeneous host within the cluster

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/StorageStrategy.java

@@ -310,7 +310,7 @@ public Volume getStorageVolume(Volume volume)
 
     /**
      * Method encapsulates the behavior based on the opted protocol in subclasses
-     @@ -306,22 +306,22 @@ public Volume getStorageVolume(Volume volume)
+     @@ -306,22 +306,22 @@ public AccessGroup getAccessGroup(Map<String, String> values)
       *     getNameSpace    for Nvme/TCP and Nvme/FC protocols
       * @param values
      */

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java

@@ -106,7 +106,7 @@ public CloudStackVolume getCloudStackVolume(Map<String, String> values) {
         String svmName = values.get(Constants.SVM_DOT_NAME);
         String lunName = values.get(Constants.NAME);
         if(svmName == null || lunName == null || svmName.isEmpty() || lunName.isEmpty()) {
-            s_logger.error("getCloudStackVolume: get Lun failed. Invalid svm:{} or igroup name: {}", svmName, lunName);
+            s_logger.error("getCloudStackVolume: get Lun failed. Invalid svm:{} or Lun name: {}", svmName, lunName);
             throw new CloudRuntimeException("getCloudStackVolume : Failed to get Lun, invalid request");
         }
         try {