vm instance creation test6

Author: Srivastava, Piyush

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

@@ -142,21 +142,24 @@ private String createCloudStackVolumeForTypeVolume(DataStore dataStore, DataObje
             CloudStackVolume cloudStackVolumeRequest = Utility.createCloudStackVolumeRequestByProtocol(storagePool, details, (VolumeInfo) dataObject);
             CloudStackVolume cloudStackVolume = storageStrategy.createCloudStackVolume(cloudStackVolumeRequest);  // Creates subdirectory on ONTAP via REST API
             String subdirectoryName = cloudStackVolume.getFile().getPath();
-            String subdirectoryPath = "/" + subdirectoryName;
-            // Store metadata in CloudStack database
+            String subdirectoryPath = subdirectoryName;  // No leading slash to avoid double slash
+            // Store metadata in CloudStack database (following CloudByte pattern)
             VolumeVO volume = volumeDao.findById(((VolumeInfo) dataObject).getId());
-            volume.set_iScsiName(subdirectoryPath);  // Subdirectory path for reference
-            volume.setPoolType(Storage.StoragePoolType.NetworkFilesystem);  // Set volume pool type for KVM adaptor selection
+            // CRITICAL: Set poolType at VOLUME level (like CloudByte does)
+            // This tells KVM to use LibvirtStorageAdaptor (NFS) instead of IscsiAdmStorageAdaptor
+            volume.setPoolType(Storage.StoragePoolType.NetworkFilesystem);
+            // Set _iScsiName for NFS (CloudByte also sets this for NFS paths)
+            // This field stores the subdirectory path for reference
+            volume.set_iScsiName(subdirectoryName);
             volume.setFolder(volumeUuid);  // Store UUID in folder field
             volume.setPoolId(dataStore.getId());
-            // CRITICAL: Set path to point to file INSIDE the subdirectory, not the subdirectory itself
-            // Subdirectory exists at: /mnt/{pool-uuid}/{volume-uuid}/
-            // We want hypervisor to create file at: /mnt/{pool-uuid}/{volume-uuid}/{volume-uuid}.{format}
-            // So path should be: /{volume-uuid}/{volume-uuid} (hypervisor adds extension)
-            String volumePath = subdirectoryPath + "/" + volumeUuid;  // e.g., /9c2e59a8.../9c2e59a8...
+            // Set path to file inside the subdirectory (no leading slash to avoid double slash)
+            // Path format: ROOT-16_865446e6.../865446e6...
+            // Full path will be: /mnt/{pool-uuid}/ROOT-16_865446e6.../865446e6....qcow2
+            String volumePath = subdirectoryPath + "/" + volumeUuid;
             volume.setPath(volumePath);
             volumeDao.update(volume.getId(), volume);
-            s_logger.info("createCloudStackVolumeForTypeVolume: NFS subdirectory '{}' created on ONTAP, volume will be created at path: {}", subdirectoryPath, volumePath);
+            s_logger.info("createCloudStackVolumeForTypeVolume: NFS subdirectory '{}' created on ONTAP, volume path: {}", subdirectoryPath, volumePath);
             return null;  // Return null - backend work done, hypervisor will handle file creation
         }
         // For iSCSI and other protocols, use ONTAP REST API