CSTACKEX-29 Added Method comments and change the ontap response class name

Author: Gupta, Surya

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/AggregateFeignClient.java

@@ -21,7 +21,7 @@
 
 import org.apache.cloudstack.storage.feign.model.Aggregate;
 import org.apache.cloudstack.storage.feign.FeignConfiguration;
-import org.apache.cloudstack.storage.feign.model.response.OnTapResponse;
+import org.apache.cloudstack.storage.feign.model.response.OntapResponse;
 import org.springframework.cloud.openfeign.FeignClient;
 import org.springframework.context.annotation.Lazy;
 import org.springframework.web.bind.annotation.PathVariable;
@@ -35,8 +35,9 @@
 @FeignClient(name="AggregateClient", url="https://{clusterIP}/api/storage/aggregates", configuration = FeignConfiguration.class)
 public interface AggregateFeignClient {
 
+    //this method to get all aggregates and also filtered aggregates based on query params as a part of URL
     @RequestMapping(method=RequestMethod.GET)
-    OnTapResponse<Aggregate> getAggregateResponse(URI baseURL, @RequestHeader("Authorization") String header);
+    OntapResponse<Aggregate> getAggregateResponse(URI baseURL, @RequestHeader("Authorization") String header);
 
     @RequestMapping(method=RequestMethod.GET, value="/{uuid}")
     Aggregate getAggregateByUUID(URI baseURL,@RequestHeader("Authorization") String header, @PathVariable(name = "uuid", required = true) String uuid);

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/SvmFeignClient.java

@@ -21,7 +21,7 @@
 
 import org.apache.cloudstack.storage.feign.FeignConfiguration;
 import org.apache.cloudstack.storage.feign.model.Svm;
-import org.apache.cloudstack.storage.feign.model.response.OnTapResponse;
+import org.apache.cloudstack.storage.feign.model.response.OntapResponse;
 import org.springframework.cloud.openfeign.FeignClient;
 import org.springframework.web.bind.annotation.RequestHeader;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -32,8 +32,9 @@
 @FeignClient(name = "SvmClient", url = "https://{clusterIP}/api/svm/svms", configuration = FeignConfiguration.class)
 public interface SvmFeignClient {
 
+    //this method to get all svms and also filtered svms based on query params as a part of URL
     @RequestMapping(method = RequestMethod.GET)
-    OnTapResponse<Svm> getSvmResponse(URI baseURL, @RequestHeader("Authorization") String header);
+    OntapResponse<Svm> getSvmResponse(URI baseURL, @RequestHeader("Authorization") String header);
 
     @RequestMapping(method = RequestMethod.GET, value = "/{uuid}")
     Svm getSvmByUUID(URI baseURL, @RequestHeader("Authorization") String header);

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/response/OnTapResponse.java renamed to plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/response/OntapResponse.java

@@ -27,18 +27,18 @@
  * OnTapResponse
  */
 @JsonInclude(JsonInclude.Include.NON_NULL)
-public class OnTapResponse<T> {
+public class OntapResponse<T> {
   @JsonProperty("num_records")
   private Integer numRecords;
 
   @JsonProperty("records")
   private List<T> records;
 
-  public OnTapResponse() {
+  public OntapResponse () {
     // Default constructor
   }
 
-  public OnTapResponse(List<T> records) {
+  public OntapResponse (List<T> records) {
     this.records = records;
     this.numRecords = (records != null) ? records.size() : 0;
   }