CSTACKEX-46 Resolve review comments

Author: Gupta, Surya

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

@@ -108,7 +108,7 @@ public void createAsync(DataStore dataStore, DataObject dataObject, AsyncComplet
             throw new InvalidParameterValueException("createAsync: callback should not be null");
         }
         try {
-            s_logger.info("createAsync: Started for data store [{}] and data object [{}] of type [{}]", dataStore, dataObject, dataObject.getType());
+            s_logger.info("createAsync: Started for data store name [{}] and data object name [{}] of type [{}]", dataStore.getName(), dataObject.getName(), dataObject.getType());
 
             StoragePoolVO storagePool = storagePoolDao.findById(dataStore.getId());
             if(storagePool == null) {
@@ -125,7 +125,7 @@ public void createAsync(DataStore dataStore, DataObject dataObject, AsyncComplet
             }
         } catch (Exception e) {
             errMsg = e.getMessage();
-            s_logger.error("createAsync: Failed for dataObject [{}]: {}", dataObject, errMsg);
+            s_logger.error("createAsync: Failed for dataObject name [{}]: {}", dataObject.getName(), errMsg);
             createCmdResult = new CreateCmdResult(null, new Answer(null, false, errMsg));
             createCmdResult.setResult(e.toString());
         } finally {
@@ -150,13 +150,12 @@ private String createCloudStackVolumeForTypeVolume(StoragePoolVO storagePool, Vo
 
     private CloudStackVolume createCloudStackVolumeRequestByProtocol(StoragePoolVO storagePool, Map<String, String> details, VolumeInfo volumeInfo) {
         CloudStackVolume cloudStackVolumeRequest = null;
-
+        Svm svm = new Svm();
+        svm.setName(details.get(Constants.SVM_NAME));
         String protocol = details.get(Constants.PROTOCOL);
         if (ProtocolType.ISCSI.name().equalsIgnoreCase(protocol)) {
             cloudStackVolumeRequest = new CloudStackVolume();
             Lun lunRequest = new Lun();
-            Svm svm = new Svm();
-            svm.setName(details.get(Constants.SVM_NAME));
             lunRequest.setSvm(svm);
 
             LunSpace lunSpace = new LunSpace();

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java

@@ -364,6 +364,7 @@ private boolean validateProtocolSupportAndFetchHostsIdentifier(List<HostVO> host
             default:
                 throw new CloudRuntimeException("validateProtocolSupportAndFetchHostsIdentifier : Unsupported protocol: " + protocolType.name());
         }
+        logger.info("validateProtocolSupportAndFetchHostsIdentifier: All hosts support the protocol: " + protocolType.name());
         return true;
     }