CSTACKEX-34: transient changes to the review comments

Author: rajiv-jain-netapp

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/StorageStrategy.java

@@ -212,6 +212,7 @@ public Volume createStorageVolume(String volumeName, Long size) {
     public Volume updateStorageVolume(Map<String,String> values)
     {
         //TODO
+        return null;
     }
 
     /**

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedNASStrategy.java

@@ -20,6 +20,8 @@
 package org.apache.cloudstack.storage.service;
 
 import org.apache.cloudstack.storage.feign.model.OntapStorage;
+import org.apache.cloudstack.storage.service.model.AccessGroup;
+import org.apache.cloudstack.storage.service.model.CloudStackVolume;
 
 import java.util.Map;
 
@@ -29,43 +31,49 @@ public UnifiedNASStrategy(OntapStorage ontapStorage) {
     }
 
     @Override
-    public void createCloudStackVolume(Map<String, String> values) {
-
+    public CloudStackVolume createCloudStackVolume(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void updateCloudStackVolume(Map<String, String> values) {
-
+    public CloudStackVolume updateCloudStackVolume(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void deleteCloudStackVolume(Map<String, String> values) {
+    public void deleteCloudStackVolume(Map<String, String> values) {
 
     }
 
     @Override
-    void getCloudStackVolume(Map<String, String> values) {
-
+    public CloudStackVolume getCloudStackVolume(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void enableAccess(Map<String, String> values) {
-
+    public AccessGroup createAccessGroup(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void disableAccess(Map<String, String> values) {
+    public void deleteAccessGroup(Map<String, String> values) {
 
     }
 
     @Override
-    void updateAccess(Map<String, String> values) {
-
+    public AccessGroup updateAccessGroup(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void getAccess(Map<String, String> values) {
-
+    public AccessGroup getAccessGroup(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java

@@ -20,6 +20,8 @@
 package org.apache.cloudstack.storage.service;
 
 import org.apache.cloudstack.storage.feign.model.OntapStorage;
+import org.apache.cloudstack.storage.service.model.AccessGroup;
+import org.apache.cloudstack.storage.service.model.CloudStackVolume;
 
 import java.util.Map;
 
@@ -29,13 +31,15 @@ public UnifiedSANStrategy(OntapStorage ontapStorage) {
     }
 
     @Override
-    public void createCloudStackVolume(Map<String, String> values) {
-
+    public CloudStackVolume createCloudStackVolume(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void updateCloudStackVolume(Map<String, String> values) {
-
+    CloudStackVolume updateCloudStackVolume(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
@@ -44,28 +48,32 @@ void deleteCloudStackVolume(Map<String, String> values) {
     }
 
     @Override
-    void getCloudStackVolume(Map<String, String> values) {
-
+    CloudStackVolume getCloudStackVolume(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void enableAccess(Map<String, String> values) {
-
+    public AccessGroup createAccessGroup(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void disableAccess(Map<String, String> values) {
+    public void deleteAccessGroup(Map<String, String> values) {
 
     }
 
     @Override
-    void updateAccess(Map<String, String> values) {
-
+    public AccessGroup updateAccessGroup(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override
-    void getAccess(Map<String, String> values) {
-
+    public AccessGroup getAccessGroup(Map<String, String> values) {
+        //TODO
+        return null;
     }
 
     @Override