vm instance creation test12

Author: Srivastava, Piyush

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

@@ -137,27 +137,26 @@ private String createCloudStackVolumeForTypeVolume(DataStore dataStore, DataObje
             // CRITICAL: Set poolType at VOLUME level
             // This tells KVM to use LibvirtStorageAdaptor (NFS) instead of IscsiAdmStorageAdaptor
             volume.setPoolType(Storage.StoragePoolType.NetworkFilesystem);
-            // Create unique volume name: name_uuid format for readability
-            // Example: ROOT-22_e4cf5d79-3a5f-4618-b3c5-f727ff3d1603
-            String volumeName = ((VolumeInfo) dataObject).getName();
+            // Use UUID only (KVM's default behavior for managed NFS)
+            // KVM's getPhysicalDisk() is hardcoded to use UUID, not custom paths
             String volumeUuid = ((VolumeInfo) dataObject).getUuid();
-            String uniqueVolumeName = volumeName + "_" + volumeUuid;
-            // Set path to the unique name so KVM can find it later
-            // This is critical - the path is what KVM uses to locate the file
-            volume.setPath(uniqueVolumeName);
+            // Set path to UUID (KVM will use this)
+            volume.setPath(volumeUuid);
             volume.setFolder("");  // No folder for flat structure
             volume.setPoolId(dataStore.getId());
             volumeDao.update(volume.getId(), volume);
-            s_logger.info("=== ONTAP Managed NFS Volume (Flat Structure) ===");
-            s_logger.info("Volume Name: {}", volumeName);
+            s_logger.info("=== ONTAP Managed NFS Volume (Flat Structure - UUID only) ===");
+            s_logger.info("Volume Name: {}", ((VolumeInfo) dataObject).getName());
             s_logger.info("Volume UUID: {}", volumeUuid);
-            s_logger.info("Volume Path: {} (name_uuid format)", uniqueVolumeName);
+            s_logger.info("Volume Path: {} (UUID-based, KVM default)", volumeUuid);
             s_logger.info("Volume PoolType: {}", volume.getPoolType());
-            s_logger.info("Hypervisor will create: /mnt/<pool>/{}.qcow2", uniqueVolumeName);
+            s_logger.info("Returning null - hypervisor will create: /mnt/<pool>/{}.qcow2", volumeUuid);
+            s_logger.info("Note: KVM's LibvirtStoragePool.getPhysicalDisk() is hardcoded to use UUID");
             s_logger.info("================================================");
-            // CRITICAL: Return the unique name (not null!)
-            // This tells CloudStack what path was created, so KVM can find it later
-            return uniqueVolumeName;
+            // CRITICAL: Return null to tell CloudStack to trigger KVM volume creation!
+            // If we return a path, CloudStack thinks volume is already created and skips KVM
+            // This causes DATA volumes to never be created
+            return null;
         }
         // For iSCSI and other protocols, use ONTAP REST API
         StorageStrategy storageStrategy = getStrategyByStoragePoolDetails(details);