vm restart issue

Author: Srivastava, Piyush

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/ExportRule.java

@@ -82,6 +82,9 @@ public static ProtocolsEnum fromValue(String text) {
     @JsonProperty("rw_rule")
     private List<String> rwRule = null;
 
+    @JsonProperty("superuser")
+    private List<String> superuser = null;
+
 
     public ExportRule anonymousUser(String anonymousUser) {
         this.anonymousUser = anonymousUser;
@@ -163,6 +166,14 @@ public void setRoRule(List<String> roRule) {
         this.roRule = roRule;
     }
 
+    public List<String> getSuperuser() {
+        return superuser;
+    }
+
+    public void setSuperuser(List<String> superuser) {
+        this.superuser = superuser;
+    }
+
     @Override
     public String toString() {
         StringBuilder sb = new StringBuilder();

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java

@@ -291,6 +291,7 @@ public boolean attachCluster(DataStore dataStore, ClusterScope scope) {
                 _storageMgr.connectHostToSharedPool(host, dataStore.getId());
             } catch (Exception e) {
                 logger.warn("Unable to establish a connection between " + host + " and " + dataStore, e);
+                throw new CloudRuntimeException("Failed to attach storage pool to cluster: " + e.getMessage(), e);
             }
         }
         _dataStoreHelper.attachCluster(dataStore);
@@ -327,6 +328,7 @@ public boolean attachZone(DataStore dataStore, ZoneScope scope, Hypervisor.Hyper
                 _storageMgr.connectHostToSharedPool(host, dataStore.getId());
             } catch (Exception e) {
                 logger.warn("Unable to establish a connection between " + host + " and " + dataStore, e);
+                throw new CloudRuntimeException("Failed to attach storage pool to host: " + e.getMessage(), e);
             }
         }
         _dataStoreHelper.attachZone(dataStore);

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/listener/OntapHostListener.java

@@ -67,9 +67,21 @@ public boolean hostConnect(long hostId, long poolId)  {
 
         // TODO add host type check also since we support only KVM for now, host.getHypervisorType().equals(HypervisorType.KVM)
         StoragePool pool = _storagePoolDao.findById(poolId);
+        if (pool == null) {
+            logger.error("Failed to connect host - storage pool not found with id: {}", poolId);
+            return false;
+        }
+        
+        // CRITICAL: Check if already connected to avoid infinite loops
+        StoragePoolHostVO existingConnection = storagePoolHostDao.findByPoolHost(poolId, hostId);
+        if (existingConnection != null && existingConnection.getLocalPath() != null && !existingConnection.getLocalPath().isEmpty()) {
+            logger.info("Host {} is already connected to storage pool {} at path {}. Skipping reconnection.", 
+                       host.getName(), pool.getName(), existingConnection.getLocalPath());
+            return true;
+        }
+        
         logger.info("Connecting host {} to ONTAP storage pool {}", host.getName(), pool.getName());
 
-
         try {
             // Create the ModifyStoragePoolCommand to send to the agent
             ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true, pool);
@@ -123,7 +135,9 @@ public boolean hostConnect(long hostId, long poolId)  {
 
         } catch (Exception e) {
             logger.error("Exception while connecting host {} to storage pool {}", host.getName(), pool.getName(), e);
-            throw new CloudRuntimeException("Failed to connect host to storage pool: " + e.getMessage(), e);
+            // CRITICAL: Don't throw exception - it crashes the agent and causes restart loops
+            // Return false to indicate failure without crashing
+            return false;
         }
         return true;
     }

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedNASStrategy.java

@@ -381,6 +381,7 @@ private ExportPolicy createExportPolicyRequest(AccessGroup accessGroup,String sv
         exportRule.setProtocols(List.of(ExportRule.ProtocolsEnum.any));
         exportRule.setRoRule(List.of("any"));
         exportRule.setRwRule(List.of("any"));
+        exportRule.setSuperuser(List.of("any")); // Allow root/superuser access for NFS writes
         rules.add(exportRule);
 
         Svm svm = new Svm();