Merge pull request #620 from NetApp/615-bug-duplicate-set-element-error-with-preferred_ad_servers-in-netapp-ontap_name_services_ldap

suhasbshekar · web-flow · commit e5e0d3acf13d · 2026-01-12T09:30:43.000-08:00
Duplicate Set Element Error with preferred_ad_servers in ontap_name_services_ldap_resource
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # 2.5.0 (2026-**-**)
 
+BUG FIXES:
+
+- **netapp-ontap_name_services_ldap_resource**: Fixed duplicate Set Element Error with `preferred_ad_servers` ([#615](https://github.com/NetApp/terraform-provider-netapp-ontap/issues/615))
+
 # 2.4.0 (2025-11-20)
 
 ENHANCEMENTS:
diff --git a/internal/provider/name_services/name_services_ldap_resource.go b/internal/provider/name_services/name_services_ldap_resource.go
@@ -298,8 +298,9 @@ func (r *NameServicesLDAPResource) Read(ctx context.Context, req resource.ReadRe
 		}
 	}
 	if restInfo.PreferredADServers != nil {
-		for _, adserver := range restInfo.PreferredADServers {
-			data.PreferredADServers = append(data.PreferredADServers, types.StringValue(adserver))
+		data.PreferredADServers = make([]types.String, len(restInfo.PreferredADServers))
+		for index, adserver := range restInfo.PreferredADServers {
+			data.PreferredADServers[index] = types.StringValue(adserver)
 		}
 	}
 	// update computed fields

Original file line number	Diff line number	Diff line change
`@@ -298,8 +298,9 @@ func (r *NameServicesLDAPResource) Read(ctx context.Context, req resource.ReadRe`
`298`	`298`	`}`
`299`	`299`	`}`
`300`	`300`	`if restInfo.PreferredADServers != nil {`
`301`		`- for _, adserver := range restInfo.PreferredADServers {`
`302`		`- data.PreferredADServers = append(data.PreferredADServers, types.StringValue(adserver))`
	`301`	`+ data.PreferredADServers = make([]types.String, len(restInfo.PreferredADServers))`
	`302`	`+ for index, adserver := range restInfo.PreferredADServers {`
	`303`	`+ data.PreferredADServers[index] = types.StringValue(adserver)`
`303`	`304`	`}`
`304`	`305`	`}`
`305`	`306`	`// update computed fields`