Update the go version to 1.25

Author: alloydsa

.github/workflows/github-actions.yml

@@ -1,6 +1,6 @@
 name: checks
 env:
-  GO_VERSION: '1.24'
+  GO_VERSION: '1.25'
 on:
   pull_request:
     branches:
@@ -43,7 +43,7 @@ jobs:
       - name: golangci-lint
         # Switch back to the official action after this bug is fixed: https://github.com/golangci/golangci-lint/issues/3107
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.1.6
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.6.0
           $(go env GOPATH)/bin/golangci-lint run --output.text.path=github-actions --timeout=15m --verbose
   go-mod-tidy:
     name: go mod tidy

.golangci.yml

@@ -1,12 +1,13 @@
 version: "2"
 run:
-  go: "1.24"
+  go: "1.25"
 linters:
   default: none
   enable:
     - errcheck
     - gosec
     - govet
+    - nakedret
   settings:
     gosec:
       excludes:
@@ -15,6 +16,8 @@ linters:
     govet:
       disable:
         - printf
+    nakedret:
+      max-func-lines: 60
     lll:
       line-length: 120
       tab-width: 4
@@ -41,12 +44,8 @@ linters:
       - examples$
 formatters:
   enable:
-    - gofumpt
     - goimports
   settings:
-    gofumpt:
-      module-path: github.com/netapp/trident
-      extra-rules: true
     goimports:
       local-prefixes:
         - github.com/netapp/trident

BUILD.md

@@ -4,16 +4,16 @@
 
 ### Single-Platform (Linux)
 
-* Docker-compatible container cli, such as nerdctl or docker
-* Make, if not building natively or with linker flags
-* Go 1.24 or greater, to optionally build Trident natively
+- Docker-compatible container cli, such as nerdctl or docker
+- Make, if not building natively or with linker flags
+- Go 1.25 or greater, to optionally build Trident natively
 
 ### Multi-Platform
 
-* Make
-* Docker
-* Go 1.24 or greater, to optionally build Trident binaries natively
-* jq
+- Make
+- Docker
+- Go 1.25 or greater, to optionally build Trident binaries natively
+- jq
 
 ## Makefile Parameters
 
@@ -32,7 +32,7 @@ Container registry used to tag images and manifests, and optionally to push imag
 
 `GO_IMAGE`
 
-Default: `golang:1.24`
+Default: `golang:1.25`
 
 Container image used by default `$GO_SHELL` to run binary build scripts.
 

Makefile

@@ -14,7 +14,7 @@ REGISTRY ?= $(DEFAULT_REGISTRY)
 BUILDX_OUTPUT ?= load
 
 # GO_IMAGE golang image used in default GO_SHELL
-GO_IMAGE ?= golang:1.24
+GO_IMAGE ?= golang:1.25
 
 # GO_CMD go command used for go build
 GO_CMD ?= go

chwrap/chwrap.go

@@ -1,7 +1,6 @@
 // Copyright 2022 NetApp, Inc. All Rights Reserved.
 
 //go:build !windows
-// +build !windows
 
 package main