Fix driver initialization failure and backend updates

Author: torirevilla

core/orchestrator_core.go

@@ -1337,8 +1337,16 @@ func (o *TridentOrchestrator) updateBackendByBackendUUID(
 		return nil, err
 	case updateCode.Contains(storage.PrefixChange):
 		err := errors.UnsupportedConfigError("updating the storage prefix isn't currently supported")
-		Logc(ctx).WithField("error", err).Error("Backend update failed.")
-		return nil, err
+		// TODO: (victorir) to unblock updating a backend 25.02. Needs refactoring.
+		Logc(ctx).WithField("error", err).Error("Backend update continuing, " +
+			"if storage prefix has been changed there may be errors.")
+		// return nil, err
+		// Update backend information
+		if err = o.updateBackendOnPersistentStore(ctx, backend, false); err != nil {
+			Logc(ctx).WithField("error", err).Errorf("Could not persist renamed backend from %v to %v",
+				originalBackend.Name(), backend.Name())
+			return nil, err
+		}
 	case updateCode.Contains(storage.BackendRename):
 		checkingBackend, lookupErr := o.getBackendByBackendName(backend.Name())
 		if lookupErr == nil {

core/orchestrator_core_test.go

@@ -7639,16 +7639,17 @@ func TestUpdateBackendByBackendUUID(t *testing.T) {
 			mocks:            func(mockStoreClient *mockpersistentstore.MockStoreClient) {},
 			wantErr:          assert.Error,
 		},
-		{
-			name:        "UpdateStoragePrefixError",
-			backendName: bName,
-			newBackendConfig: map[string]interface{}{
-				"version": 1, "storageDriverName": "fake", "backendName": bName,
-				"storagePrefix": "new", "protocol": config.File,
-			},
-			mocks:   func(mockStoreClient *mockpersistentstore.MockStoreClient) {},
-			wantErr: assert.Error,
-		},
+		// TODO: (victorir) to unblock updating a backend 25.02. Needs refactoring.
+		// {
+		// 	name:        "UpdateStoragePrefixError",
+		// 	backendName: bName,
+		// 	newBackendConfig: map[string]interface{}{
+		// 		"version": 1, "storageDriverName": "fake", "backendName": bName,
+		// 		"storagePrefix": "new", "protocol": config.File,
+		// 	},
+		// 	mocks:   func(mockStoreClient *mockpersistentstore.MockStoreClient) {},
+		// 	wantErr: assert.Error,
+		// },
 		{
 			name:        "BackendRenameWithExistingNameError",
 			backendName: bName,

storage_drivers/ontap/ontap_factory.go

@@ -1,4 +1,4 @@
-// Copyright 2024 NetApp, Inc. All Rights Reserved.
+// Copyright 2025 NetApp, Inc. All Rights Reserved.
 
 package ontap
 
@@ -30,6 +30,7 @@ func GetStorageDriver(
 	ctx context.Context, configJSON string, commonConfig *drivers.CommonStorageDriverConfig,
 	backendSecret map[string]string,
 ) (storage.Driver, error) {
+	var storageDriver storage.Driver
 	driverProtocol, err := GetDriverProtocol(commonConfig.StorageDriverName, configJSON)
 	if err != nil {
 		Logc(ctx).WithField("error", err).Error("Failed to get driver protocol.")
@@ -51,8 +52,13 @@ func GetStorageDriver(
 
 	// Initialize the ONTAP API.
 	API, err := InitializeOntapDriver(ctx, ontapConfig)
-	if err != nil {
-		return nil, fmt.Errorf("error initializing %s driver: %v", commonConfig.StorageDriverName, err)
+	if API == nil {
+		Logc(ctx).WithError(err).Errorf("error initializing %s driver", commonConfig.StorageDriverName)
+		storageDriver, err = getEmptyStorageDriver(commonConfig.StorageDriverName, driverProtocol)
+		if err != nil {
+			return nil, err
+		}
+		return storageDriver, nil
 	}
 
 	// Set up driver flags
@@ -62,7 +68,6 @@ func GetStorageDriver(
 		FlagSANOptimized:  strconv.FormatBool(API.IsSANOptimized()),
 	}
 
-	var storageDriver storage.Driver
 	switch ontapConfig.StorageDriverName {
 
 	case config.OntapNASStorageDriverName:
@@ -107,6 +112,32 @@ func GetStorageDriver(
 	return storageDriver, nil
 }
 
+func getEmptyStorageDriver(driverName, driverProtocol string) (storage.Driver, error) {
+	var storageDriver storage.Driver
+
+	// Pre-driver initialization setup
+	switch driverName {
+	case config.OntapNASStorageDriverName:
+		storageDriver = &NASStorageDriver{}
+	case config.OntapNASFlexGroupStorageDriverName:
+		storageDriver = &NASFlexGroupStorageDriver{}
+	case config.OntapNASQtreeStorageDriverName:
+		storageDriver = &NASQtreeStorageDriver{}
+	case config.OntapSANStorageDriverName:
+		if driverProtocol == sa.ISCSI || driverProtocol == sa.FCP {
+			storageDriver = &SANStorageDriver{}
+		} else {
+			storageDriver = &NVMeStorageDriver{}
+		}
+	case config.OntapSANEconomyStorageDriverName:
+		storageDriver = &SANEconomyStorageDriver{}
+	default:
+		return nil, fmt.Errorf("unknown storage driver: %v", driverName)
+	}
+
+	return storageDriver, nil
+}
+
 // GetDriverProtocol returns the protocol type for SAN Drivers using the backend config.
 // This function can be extended for NAS drivers if required.
 func GetDriverProtocol(driverName, configJSON string) (string, error) {