Update go version to 1.24

Signed-off-by: Meghna Singh <[email protected]>

Author: singhmeghna79

.github/workflows/github-actions.yml

@@ -1,6 +1,6 @@
 name: checks
 env:
-  GO_VERSION: '1.23'
+  GO_VERSION: '1.24'
 on:
   pull_request:
     branches:
@@ -42,8 +42,8 @@ jobs:
       - name: golangci-lint
         # Switch back to the official action after this bug is fixed: https://github.com/golangci/golangci-lint/issues/3107
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.61.0
-          $(go env GOPATH)/bin/golangci-lint run --out-format=github-actions --timeout=15m --verbose
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.1.6
+          $(go env GOPATH)/bin/golangci-lint run --output.text.path=github-actions --timeout=15m --verbose
   go-mod-tidy:
     name: go mod tidy
     runs-on: ubuntu-latest

.golangci.yml

@@ -1,55 +1,58 @@
+version: "2"
 run:
-  timeout: 5m
-  go: 1.23
-
+  go: "1.24"
 linters:
-  disable-all: true
-  # Enable specific linter
-  # https://golangci-lint.run/usage/linters/#enabled-by-default-linters
+  default: none
   enable:
-    - gofumpt
-    - goimports
-    - govet
     - errcheck
     - gosec
-
-issues:
-  exclude-rules:
-    # Exclude some linters from running on tests files.
-    - path: _test\.go
-      linters:
-        - gocyclo
-        - errcheck
-        - dupl
-        - gosec
-    # Exclude `lll` issues for long lines with `go:generate`.
-    - linters:
-        - lll
-      source: "^//go:generate "
-
-linters-settings:
-  gofumpt:
-    extra-rules: true
-    module-path: github.com/netapp/trident
-
-  goimports:
-    # Put imports beginning with prefix after 3rd-party packages.
-    # It's a comma-separated list of prefixes.
-    local-prefixes: github.com/netapp/trident
-
-  lll:
-    # Max line length, lines longer will be reported.
-    # '\t' is counted as 1 character by default, and can be changed with the tab-width option.
-    line-length: 120
-    # Tab width in spaces.
-    tab-width: 4
-
-  gosec:
-    excludes:
-      # Exclude TLS client side erorrs for now, until Trident fully supports TLS1.3
-      - G402 # Look for bad TLS connection settings
-      - G115
-
-  govet:
-    disable:
-      - printf
+    - govet
+  settings:
+    gosec:
+      excludes:
+        - G402
+        - G115
+    govet:
+      disable:
+        - printf
+    lll:
+      line-length: 120
+      tab-width: 4
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - dupl
+          - errcheck
+          - gocyclo
+          - gosec
+        path: _test\.go
+      - linters:
+          - lll
+        source: '^//go:generate '
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofumpt
+    - goimports
+  settings:
+    gofumpt:
+      module-path: github.com/netapp/trident
+      extra-rules: true
+    goimports:
+      local-prefixes:
+        - github.com/netapp/trident
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

BUILD.md

@@ -6,13 +6,13 @@
 
 * Docker-compatible container cli, such as nerdctl or docker
 * Make, if not building natively or with linker flags
-* Go 1.23 or greater, to optionally build Trident natively
+* Go 1.24 or greater, to optionally build Trident natively
 
 ### Multi-Platform
 
 * Make
 * Docker
-* Go 1.23 or greater, to optionally build Trident binaries natively
+* Go 1.24 or greater, to optionally build Trident binaries natively
 * jq
 
 ## Makefile Parameters
@@ -32,7 +32,7 @@ Container registry used to tag images and manifests, and optionally to push imag
 
 `GO_IMAGE`
 
-Default: `golang:1.23`
+Default: `golang:1.24`
 
 Container image used by default `$GO_SHELL` to run binary build scripts.
 

Makefile

@@ -14,7 +14,7 @@ REGISTRY ?= $(DEFAULT_REGISTRY)
 BUILDX_OUTPUT ?= load
 
 # GO_IMAGE golang image used in default GO_SHELL
-GO_IMAGE ?= golang:1.23
+GO_IMAGE ?= golang:1.24
 
 # GO_CMD go command used for go build
 GO_CMD ?= go

acp/client.go

@@ -4,7 +4,6 @@ package acp
 
 import (
 	"context"
-	"fmt"
 	"time"
 
 	"github.com/cenkalti/backoff/v4"
@@ -75,7 +74,7 @@ func (c *client) GetVersion(ctx context.Context) (*version.Version, error) {
 
 	if acpVersion == nil {
 		Logc(ctx).Error("No version in response from Trident-ACP REST API.")
-		return nil, fmt.Errorf("no version in response from Trident-ACP REST API")
+		return nil, errors.New("no version in response from Trident-ACP REST API")
 	}
 
 	Logc(ctx).WithField("version", acpVersion.String()).Debug("Received Trident-ACP version.")
@@ -116,7 +115,7 @@ func (c *client) GetVersionWithBackoff(ctx context.Context) (*version.Version, e
 		return nil, err
 	} else if v == nil {
 		Logc(ctx).Error("No version in response from Trident-ACP REST API.")
-		return nil, fmt.Errorf("no version in response from Trident-ACP REST API")
+		return nil, errors.New("no version in response from Trident-ACP REST API")
 	}
 
 	Logc(ctx).WithField("version", v.String()).Debug("The Trident-ACP REST API is responsive.")

cli/cmd/check_operator_test.go

@@ -3,7 +3,6 @@
 package cmd
 
 import (
-	"fmt"
 	"io"
 	"os"
 	"testing"
@@ -15,6 +14,7 @@ import (
 
 	"github.com/netapp/trident/cli/api"
 	mockexec "github.com/netapp/trident/mocks/mock_utils/mock_exec"
+	"github.com/netapp/trident/utils/errors"
 	execCmd "github.com/netapp/trident/utils/exec"
 )
 
@@ -89,7 +89,7 @@ func TestCheckOperatorStatus_RequestError(t *testing.T) {
 	defer httpmock.DeactivateAndReset()
 
 	httpmock.RegisterResponder("GET", url,
-		httpmock.NewErrorResponder(fmt.Errorf("random error")))
+		httpmock.NewErrorResponder(errors.New("random error")))
 
 	err := checkOperatorStatus(1)
 

cli/cmd/update_backend_state.go

@@ -51,7 +51,7 @@ func validateUpdateBackendStateArguments(cmd *cobra.Command, args []string) erro
 	}
 
 	if flagSet != 1 {
-		return fmt.Errorf("exactly one of --state or --user-state must be specified")
+		return errors.New("exactly one of --state or --user-state must be specified")
 	}
 
 	return nil

cli/cmd/update_backend_state_test.go

@@ -4,7 +4,6 @@ package cmd
 
 import (
 	"bytes"
-	"fmt"
 	"io"
 	"net/http"
 	"os"
@@ -21,6 +20,7 @@ import (
 	"github.com/netapp/trident/frontend/rest"
 	mockexec "github.com/netapp/trident/mocks/mock_utils/mock_exec"
 	"github.com/netapp/trident/storage"
+	"github.com/netapp/trident/utils/errors"
 	execCmd "github.com/netapp/trident/utils/exec"
 )
 
@@ -393,7 +393,7 @@ func TestUpdateBackendState(t *testing.T) {
 			urlUpdateBackendResponse: BaseURL() + "/backend/" + backends[0].Name + "/state",
 			urlGetBackendResponse:    BaseURL() + "/backend/" + backends[0].Name,
 			updateBackendResponse: func(req *http.Request) (*http.Response, error) {
-				return nil, fmt.Errorf("trident server not found")
+				return nil, errors.New("trident server not found")
 			},
 			matchOutput: false,
 		},

cli/k8s_client/feature_gate.go

@@ -91,7 +91,7 @@ func (g autoFeatureGate) Gates() map[string]string {
 // If some but not all feature gates are safe to enable, they will be returned along with an error.
 func ConstructCSIFeatureGateYAMLSnippets(client KubernetesClient) (map[string]string, error) {
 	if client == nil {
-		return nil, fmt.Errorf("k8s API client is nil; cannot auto-enable feature gates")
+		return nil, errors.New("k8s API client is nil; cannot auto-enable feature gates")
 	}
 
 	// Automatically enable feature gates.

cli/k8s_client/k8s_client_test.go

@@ -4,7 +4,6 @@ package k8sclient
 
 import (
 	"encoding/json"
-	"fmt"
 	"io"
 	"os"
 	"testing"
@@ -22,7 +21,7 @@ import (
 	"github.com/netapp/trident/utils/errors"
 )
 
-var mockError = fmt.Errorf("mock error")
+var mockError = errors.New("mock error")
 
 func TestMain(m *testing.M) {
 	// Disable any standard log output