Fixing node race condition bug, due to uint32 being read without any concurrent measure.

shashank-netapp · web-flow · commit 2a346534ba33 · 2025-06-13T18:06:08.000+05:30
Signed-off-by: Shashank Pal &lt;pshashan@netapp.com&gt;
diff --git a/pkg/locks/locks.go b/pkg/locks/locks.go
@@ -65,7 +65,7 @@ func DecrementQueueSize(lockID string) {
 	currentWait, ok := waitQueue.Load(lockID)
 	if ok {
 		if ptr, ok := currentWait.(*uint32); ok {
-			if *ptr > 0 {
+			if atomic.LoadUint32(ptr) > 0 {
 				atomic.AddUint32(ptr, ^uint32(0))
 			}
 		}
diff --git a/utils/limiter/semaphoreN_test.go b/utils/limiter/semaphoreN_test.go
@@ -59,7 +59,7 @@ func TestSemaphoreN_Wait(t *testing.T) {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()
-			err = lim.Wait(ctx)
+			err := lim.Wait(ctx)
 			defer lim.Release(ctx)
 			assert.NoError(t, err)
 		}()

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ func DecrementQueueSize(lockID string) {`
`65`	`65`	`currentWait, ok := waitQueue.Load(lockID)`
`66`	`66`	`if ok {`
`67`	`67`	`if ptr, ok := currentWait.(*uint32); ok {`
`68`		`- if *ptr > 0 {`
	`68`	`+ if atomic.LoadUint32(ptr) > 0 {`
`69`	`69`	`atomic.AddUint32(ptr, ^uint32(0))`
`70`	`70`	`}`
`71`	`71`	`}`