Qtree async delete fix

Author: torirevilla

storage_drivers/ontap/api/ontap_rest.go

@@ -4903,7 +4903,20 @@ func (c *RestClient) QtreeDestroyAsync(ctx context.Context, path string, force b
 		return nil
 	} else if deleteAccepted != nil {
 		jobLink := getGenericJobLinkFromQtreeJobLink(deleteAccepted.Payload)
-		return c.PollJobStatus(ctx, jobLink)
+		job := jobLink.Job
+		if job == nil {
+			return fmt.Errorf("missing job result")
+		}
+		if job.UUID == nil {
+			return fmt.Errorf("missing job uuid for result")
+		}
+		jobUUID := *job.UUID
+		// qtree files take a long time to delete, so we return immediately without polling for job completion.
+		Logc(ctx).WithFields(LogFields{
+			"path":    path,
+			"jobUUID": jobUUID,
+		}).Debug("Qtree deleting asynchronously.")
+		return nil
 	}
 	return fmt.Errorf("unexpected response from qtree delete")
 }

storage_drivers/ontap/api/ontap_rest_test.go

@@ -6552,16 +6552,40 @@ func TestOntapQtree_DestroyAsync(t *testing.T) {
 	}
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			server := httptest.NewServer(http.HandlerFunc(test.mockFunction))
+			var requests []struct {
+				Method string
+				Path   string
+			}
+			var mu sync.Mutex
+			handler := func(w http.ResponseWriter, r *http.Request) {
+				mu.Lock()
+				requests = append(requests, struct {
+					Method string
+					Path   string
+				}{Method: r.Method, Path: r.URL.Path})
+				mu.Unlock()
+				test.mockFunction(w, r)
+			}
+
+			server := httptest.NewServer(http.HandlerFunc(handler))
+
 			rs := newRestClient(server.Listener.Addr().String(), server.Client())
 			assert.NotNil(t, rs)
 
 			err := rs.QtreeDestroyAsync(ctx, "/vol1/qtree_vol1", false)
 			if !test.isErrorExpected {
 				assert.NoError(t, err, "could not delete the qtree")
+				mu.Lock()
+				assert.Len(t, requests, 2, "expected exactly 2 requests (qtree lookup + delete); job poll would add GET to cluster/jobs")
+				for _, req := range requests {
+					assert.NotRegexp(t, `.*/cluster/jobs/.*`, req.Path,
+						"must not poll job endpoint when qtree delete returns 202 Accepted; got %s %s", req.Method, req.Path)
+				}
+				mu.Unlock()
 			} else {
 				assert.Error(t, err, "qtree deleted")
 			}
+
 			server.Close()
 		})
 	}