Add Ontap AFX support for NAS driver

Signed-off-by: Meghna Singh <[email protected]>

Author: singhmeghna79

Makefile

@@ -470,3 +470,12 @@ lint-precommit: .git/hooks install-lint
 
 lint-prepush: .git/hooks install-lint .git/hooks/pre-push
 	@cp hooks/golangci-lint.sh .git/hooks/pre-push
+
+EXCLUDE_PACKAGES := client/clientset client/informers client/listers storage/external_test astrads/api/v1alpha1 ontap/api/azgo ontap/api/rest fake github.com/netapp/trident/mocks/ github.com/netapp/trident/operator/controllers/provisioner github.com/netapp/trident/operator/controllers/provisioner/apis/netapp/v1 github.com/netapp/trident/storage_drivers/astrads/api/v1beta1
+
+test-coverage:
+	@EXCLUDE_PATTERN=$$(echo $(EXCLUDE_PACKAGES) | sed 's/ /|/g'); \
+	packages=$$(go list ./... | grep -Ev "$$EXCLUDE_PATTERN"); \
+	go test -v -short -p 1 -coverprofile=coverage.out $$packages; \
+	OVERALL_COVERAGE=$$(go tool cover -func=coverage.out | grep total | awk '{print $$3}'); \
+	echo "Overall coverage: $$OVERALL_COVERAGE"

storage_drivers/ontap/api/abstraction_rest.go

@@ -177,7 +177,12 @@ func (d OntapAPIREST) VolumeCreate(ctx context.Context, volume Volume) error {
 	defer Logd(ctx, d.driverName,
 		d.api.ClientConfig().DebugTraceFlags["method"]).WithFields(fields).Trace("<<<< VolumeCreate")
 
-	creationErr := d.api.VolumeCreate(ctx, volume.Name, volume.Aggregates[0], volume.Size, volume.SpaceReserve,
+	aggregateName := ""
+	if len(volume.Aggregates) > 0 {
+		aggregateName = volume.Aggregates[0]
+	}
+
+	creationErr := d.api.VolumeCreate(ctx, volume.Name, aggregateName, volume.Size, volume.SpaceReserve,
 		volume.SnapshotPolicy, volume.UnixPermissions, volume.ExportPolicy, volume.SecurityStyle,
 		volume.TieringPolicy, volume.Comment, volume.Qos, volume.Encrypt, volume.SnapshotReserve, volume.DPVolume)
 	if creationErr != nil {

storage_drivers/ontap/api/ontap_rest.go

@@ -4623,6 +4623,10 @@ func (c *RestClient) ExportRuleDestroy(
 func ToSliceVolumeAggregatesItems(aggrs []string) []*models.VolumeInlineAggregatesInlineArrayItem {
 	var result []*models.VolumeInlineAggregatesInlineArrayItem
 	for _, aggregateName := range aggrs {
+		// Skip empty aggregate names
+		if strings.TrimSpace(aggregateName) == "" {
+			continue
+		}
 		item := &models.VolumeInlineAggregatesInlineArrayItem{
 			Name: convert.ToPtr(aggregateName),
 		}