Improve code coverage for frontend/csi package

Author: singhmeghna79

frontend/csi/controller_helpers/kubernetes/utils_test.go

@@ -6,6 +6,8 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	v1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/version"
 
 	"github.com/netapp/trident/frontend/csi"
@@ -42,3 +44,135 @@ func TestGetDataSizeFromTotalSize(t *testing.T) {
 
 	assert.Equal(t, expectedDataSize, result, "Data size not as expected")
 }
+
+func TestValidateKubeVersion(t *testing.T) {
+	testCases := []struct {
+		name        string
+		kubeVersion *version.Info
+		assertErr   assert.ErrorAssertionFunc
+	}{
+		{
+			name: "Valid version",
+			kubeVersion: &version.Info{
+				GitVersion: "v1.28.0",
+				Major:      "1",
+				Minor:      "28",
+			},
+			assertErr: assert.NoError,
+		},
+		{
+			name: "Unsupported version",
+			kubeVersion: &version.Info{
+				GitVersion: "v1.15.0", // Below supported version, triggers warning
+				Major:      "1",
+				Minor:      "15",
+			},
+			assertErr: assert.NoError, // Warning is logged, but no error returned
+		},
+		{
+			name: "Invalid semantic version",
+			kubeVersion: &version.Info{
+				GitVersion: "invalid-version",
+				Major:      "1",
+				Minor:      "xx",
+			},
+			assertErr: assert.Error,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			h := &helper{
+				kubeVersion: tc.kubeVersion,
+			}
+			err := h.validateKubeVersion()
+
+			tc.assertErr(t, err)
+		})
+	}
+}
+
+func TestGetStorageClassForPVC(t *testing.T) {
+	class := "gold"
+
+	testCases := []struct {
+		name          string
+		pvc           *v1.PersistentVolumeClaim
+		expectedClass string
+	}{
+		{
+			name: "StorageClass set",
+			pvc: &v1.PersistentVolumeClaim{
+				Spec: v1.PersistentVolumeClaimSpec{
+					StorageClassName: &class,
+				},
+			},
+			expectedClass: "gold",
+		},
+		{
+			name: "StorageClass nil",
+			pvc: &v1.PersistentVolumeClaim{
+				Spec: v1.PersistentVolumeClaimSpec{
+					StorageClassName: nil,
+				},
+			},
+			expectedClass: "",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			result := getStorageClassForPVC(tc.pvc)
+			assert.Equal(t, tc.expectedClass, result)
+		})
+	}
+}
+
+func TestCheckValidStorageClassReceived(t *testing.T) {
+	ctx := context.Background()
+	class := "standard"
+
+	testCases := []struct {
+		name      string
+		pvc       *v1.PersistentVolumeClaim
+		assertErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "Valid storage class",
+			pvc: &v1.PersistentVolumeClaim{
+				ObjectMeta: metav1.ObjectMeta{Name: "pvc1"},
+				Spec: v1.PersistentVolumeClaimSpec{
+					StorageClassName: &class,
+				},
+			},
+			assertErr: assert.NoError,
+		},
+		{
+			name: "Nil storage class",
+			pvc: &v1.PersistentVolumeClaim{
+				ObjectMeta: metav1.ObjectMeta{Name: "pvc2"},
+				Spec:       v1.PersistentVolumeClaimSpec{},
+			},
+			assertErr: assert.Error,
+		},
+		{
+			name: "Empty storage class",
+			pvc: &v1.PersistentVolumeClaim{
+				ObjectMeta: metav1.ObjectMeta{Name: "pvc3"},
+				Spec: v1.PersistentVolumeClaimSpec{
+					StorageClassName: new(string), // empty string pointer
+				},
+			},
+			assertErr: assert.Error,
+		},
+	}
+
+	h := &helper{}
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			err := h.checkValidStorageClassReceived(ctx, tc.pvc)
+
+			tc.assertErr(t, err)
+		})
+	}
+}