Fix REST API volume lookup to ignore volume state

VinayKumarHavanur · web-flow · commit aafa1148c11e · 2025-12-20T14:13:58.000+05:30
diff --git a/storage_drivers/ontap/api/ontap_rest.go b/storage_drivers/ontap/api/ontap_rest.go
@@ -626,7 +626,7 @@ func (c *RestClient) getVolumeByNameAndStyle(
 	style string,
 	fields []string,
 ) (*models.Volume, error) {
-	result, err := c.getAllVolumesByPatternStyleAndState(ctx, volumeName, style, models.VolumeStateOnline, fields)
+	result, err := c.getAllVolumesByPatternStyleAndState(ctx, volumeName, style, "", fields)
 	if err != nil {
 		return nil, err
 	}
diff --git a/storage_drivers/ontap/api/ontap_rest_test.go b/storage_drivers/ontap/api/ontap_rest_test.go
@@ -4591,6 +4591,8 @@ func TestGetAllVolumesByPatternStyleAndState_failure(t *testing.T) {
 		{"InvalidStyle", "InvalidState", mockGetVolumeResponse, true},
 		{models.VolumeStyleFlexvol, "InvalidState", mockGetVolumeResponse, true},
 		{models.VolumeStyleFlexvol, models.VolumeStateOnline, mockGetVolumeResponseNumRecordsNil, false},
+		{models.VolumeStyleFlexvol, "", mockGetVolumeResponse, false},
+		{models.VolumeStyleFlexvol, "", mockGetVolumeResponseNumRecordsNil, false},
 	}
 
 	for _, test := range tests {

Original file line number	Diff line number	Diff line change
`@@ -626,7 +626,7 @@ func (c *RestClient) getVolumeByNameAndStyle(`
`626`	`626`	`style string,`
`627`	`627`	`fields []string,`
`628`	`628`	`) (*models.Volume, error) {`
`629`		`- result, err := c.getAllVolumesByPatternStyleAndState(ctx, volumeName, style, models.VolumeStateOnline, fields)`
	`629`	`+ result, err := c.getAllVolumesByPatternStyleAndState(ctx, volumeName, style, "", fields)`
`630`	`630`	`if err != nil {`
`631`	`631`	`return nil, err`
`632`	`632`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4591,6 +4591,8 @@ func TestGetAllVolumesByPatternStyleAndState_failure(t *testing.T) {`
`4591`	`4591`	`{"InvalidStyle", "InvalidState", mockGetVolumeResponse, true},`
`4592`	`4592`	`{models.VolumeStyleFlexvol, "InvalidState", mockGetVolumeResponse, true},`
`4593`	`4593`	`{models.VolumeStyleFlexvol, models.VolumeStateOnline, mockGetVolumeResponseNumRecordsNil, false},`
	`4594`	`+ {models.VolumeStyleFlexvol, "", mockGetVolumeResponse, false},`
	`4595`	`+ {models.VolumeStyleFlexvol, "", mockGetVolumeResponseNumRecordsNil, false},`
`4594`	`4596`	`}`
`4595`	`4597`
`4596`	`4598`	`for _, test := range tests {`