Fixing unit test

Author: aparna0508

storage_drivers/ontap/ontap_asa_test.go

@@ -6,7 +6,6 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"sort"
 	"strings"
 	"testing"
 	"time"
@@ -2534,7 +2533,7 @@ func TestGetStorageBackendSpecsASA(t *testing.T) {
 	assert.Equal(t, backend.Name(), driver.BackendName(), "Should be equal")
 
 	expectedPhysicalPoolsName := []string{"dummyPool1", "dummyPool2"}
-	assert.Equal(t, expectedPhysicalPoolsName, backend.GetPhysicalPoolNames(ctx))
+	assert.ElementsMatch(t, expectedPhysicalPoolsName, backend.GetPhysicalPoolNames(ctx), "Physical pool names do not match")
 }
 
 func TestGetStorageBackendPhysicalPoolNamesASA(t *testing.T) {
@@ -2558,13 +2557,9 @@ func TestGetStorageBackendPhysicalPoolNamesASA(t *testing.T) {
 	driver.physicalPools = physicalPools
 
 	expectedPhysicalPoolsName := []string{"dummyPool1", "dummyPool2"}
-
 	actualPhysicalPoolsName := driver.GetStorageBackendPhysicalPoolNames(ctx)
 
-	sort.Strings(expectedPhysicalPoolsName)
-	sort.Strings(actualPhysicalPoolsName)
-
-	assert.Equal(t, expectedPhysicalPoolsName, actualPhysicalPoolsName, "Should be equal")
+	assert.ElementsMatch(t, expectedPhysicalPoolsName, actualPhysicalPoolsName, "Should be equal")
 }
 
 func TestGetBackendStateASA(t *testing.T) {

utils/lsblk/lsblk_darwin.go

@@ -14,7 +14,8 @@ func (l *LsblkUtil) GetBlockDevices(ctx context.Context) ([]BlockDevice, error)
 }
 
 func (l *LsblkUtil) FindParentDevice(ctx context.Context, deviceName string, devices []BlockDevice,
-	parent *BlockDevice) (*BlockDevice, error) {
+	parent *BlockDevice,
+) (*BlockDevice, error) {
 	Logc(ctx).Debug(">>>> lsblk_darwin.FindParentDevice")
 	defer Logc(ctx).Debug("<<<< lsblk_darwin.FindParentDevice")
 	return nil, errors.UnsupportedError("FindParentDevice is not supported for darwin")

utils/lsblk/lsblk_darwin_test.go

@@ -26,8 +26,8 @@ func TestFindParentDevice(t *testing.T) {
 	assert.Nil(t, devices)
 	assert.Error(t, err)
 	assert.Contains(t, err.Error(), "not supported")
-
 }
+
 func TestGetParentDeviceKname(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	lsblk := NewLsblkUtilDetailed(mock_exec.NewMockCommand(ctrl))

utils/nvme/nvme_darwin.go

@@ -47,7 +47,8 @@ func (s *NVMeSubsystem) DisconnectSubsystemFromHost(ctx context.Context) error {
 }
 
 func (nh *NVMeHandler) GetNVMeSubsystem(ctx context.Context, nqn string) (*NVMeSubsystem,
-	error) {
+	error,
+) {
 	Logc(ctx).Debug(">>>> nvme_darwin.GetNVMeSubsystem")
 	defer Logc(ctx).Debug("<<<< nvme_darwin.GetNVMeSubsystem")
 	return &NVMeSubsystem{}, errors.UnsupportedError("GetNVMeSubsystem is not supported for darwin")