Fixed the exit status being returned in luksFormat function instead of actual error

Author: shashank-netapp

utils/devices/luks/luks_linux.go

@@ -108,7 +108,7 @@ func (d *LUKSDevice) luksFormat(ctx context.Context, luksPassphrase string) erro
 			"device": device,
 			"output": string(output),
 		}).WithError(err).Error("Failed to format LUKS device.")
-		return fmt.Errorf("could not format LUKS device; %w", err)
+		return errors.FormatError(fmt.Errorf("could not format LUKS device; %v", string(output)))
 	}
 
 	return nil

utils/errors/errors.go

@@ -989,3 +989,24 @@ func IsNotManagedError(err error) bool {
 	var errPtr *notManagedError
 	return errors.As(err, &errPtr)
 }
+
+// ///////////////////////////////////////////////////////////////////////////
+// formatError
+// ///////////////////////////////////////////////////////////////////////////
+
+type formatError struct {
+	message string
+}
+
+func (f *formatError) Error() string { return f.message }
+
+func FormatError(err error) error {
+	return &formatError{
+		fmt.Sprintf("Formatting failed; %s", err.Error()),
+	}
+}
+
+func IsFormatError(err error) bool {
+	var f *formatError
+	return errors.As(err, &f)
+}

utils/errors/errors_test.go

@@ -459,3 +459,43 @@ func TestReconcileFailedError(t *testing.T) {
 	assert.True(t, IsReconcileFailedError(err))
 	assert.Equal(t, "outer; inner; ", err.Error())
 }
+
+func TestFormatError(t *testing.T) {
+	err := FormatError(fmt.Errorf("formatting error"))
+	assert.True(t, IsFormatError(err))
+	assert.Equal(t, "Formatting failed; formatting error", err.Error())
+}
+
+func TestIsFormatError(t *testing.T) {
+	formatErr := &formatError{
+		message: "format error",
+	}
+
+	tests := []struct {
+		Name    string
+		Err     error
+		wantErr assert.BoolAssertionFunc
+	}{
+		{
+			Name:    "NotFormatError",
+			Err:     fmt.Errorf("a generic error"),
+			wantErr: assert.False,
+		},
+		{
+			Name:    "FormatError",
+			Err:     formatErr,
+			wantErr: assert.True,
+		},
+		{
+			Name:    "WrappedFormatError",
+			Err:     fmt.Errorf("wrapping formatError; %w", formatErr),
+			wantErr: assert.True,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.Name, func(t *testing.T) {
+			tt.wantErr(t, IsFormatError(tt.Err), "Unexpected error")
+		})
+	}
+}