Log error when trying to clone from different storage class driver

Author: alloydsa

core/concurrent_core.go

@@ -2183,6 +2183,11 @@ func (o *ConcurrentTridentOrchestrator) cloneVolume(
 		return nil, errors.NotFoundError("backend for source volume %s not found", volConfig.CloneSourceVolume)
 	}
 
+	if volConfig.StorageClass != sourceVolume.Config.StorageClass {
+		Logc(ctx).Errorf("Clone volume %s from source volume %s with different storage classes is not recommended.",
+			volConfig.Name, volConfig.CloneSourceVolume)
+	}
+
 	if volConfig.Size != "" {
 		cloneSourceVolumeSize, err := strconv.ParseInt(sourceVolume.Config.Size, 10, 64)
 		if err != nil {
@@ -2367,6 +2372,11 @@ func (o *ConcurrentTridentOrchestrator) cloneVolumeRetry(
 
 	Logc(ctx).WithFields(logFields).Debug("Cloning volume.")
 
+	if cloneConfig.StorageClass != sourceVolConfig.StorageClass {
+		Logc(ctx).Errorf("Clone volume %s from source volume %s with different storage classes is not recommended.",
+			cloneConfig.Name, cloneConfig.CloneSourceVolume)
+	}
+
 	// Create the volume
 	createVolume := func() error {
 		if volume, err = backend.CloneVolume(ctx, sourceVolConfig, cloneConfig, pool, false); err != nil {

core/orchestrator_core.go

@@ -2290,6 +2290,11 @@ func (o *TridentOrchestrator) cloneVolumeInitial(
 		return nil, errors.NotFoundError("source volume not found: %s", volumeConfig.CloneSourceVolume)
 	}
 
+	if volumeConfig.StorageClass != sourceVolume.Config.StorageClass {
+		Logc(ctx).Errorf("Clone volume %s from source volume %s with different storage classes is not recommended.",
+			volumeConfig.Name, volumeConfig.CloneSourceVolume)
+	}
+
 	Logc(ctx).WithFields(LogFields{
 		"Config.Size": sourceVolume.Config.Size,
 	}).Trace("Checking volume size.")
@@ -2525,6 +2530,11 @@ func (o *TridentOrchestrator) cloneVolumeRetry(
 		return nil, errors.NotFoundError("source volume not found: %s", cloneConfig.CloneSourceVolume)
 	}
 
+	if cloneConfig.StorageClass != sourceVolume.Config.StorageClass {
+		Logc(ctx).Errorf("Clone volume %s from source volume %s with different storage classes is not recommended.",
+			cloneConfig.Name, cloneConfig.CloneSourceVolume)
+	}
+
 	backend, found = o.backends[txn.VolumeCreatingConfig.BackendUUID]
 	if !found {
 		// Should never get here but just to be safe