Skip to content

Commit 77a1ef4

Browse files
committed
rtl_433: Minor rototill (comment out old stuff)
Comment out a number of things likely leftover from much older cmake support. Add comments that various things need fixing or justifying.
1 parent 8a5e260 commit 77a1ef4

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed

rtl_433/Makefile

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
GITHUB_PROJECT= rtl_433
44
GITHUB_TAG= 23.11
5-
DISTNAME= 23.11
5+
DISTNAME= ${GITHUB_TAG}
66
PKGNAME= ${GITHUB_PROJECT}-${DISTNAME}
77
CATEGORIES= ham
88
MASTER_SITES= ${MASTER_SITE_GITHUB:=merbanan/}
@@ -19,33 +19,42 @@ USE_LANGUAGES= c c++
1919
USE_TOOLS+= pkg-config pax
2020
AUTO_MKDIRS= yes
2121

22-
CMAKE_CONFIGURE_ARGS+= -Wno-dev
23-
CMAKE_CONFIGURE_ARGS+= -DCMAKE_INSTALL_MANDIR=${PREFIX}/${PKGMANDIR}
24-
CMAKE_CONFIGURE_ARGS+= -DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE
25-
CMAKE_CONFIGURE_ARGS+= -DCMAKE_INSTALL_PREFIX=${PREFIX}
26-
CMAKE_CONFIGURE_ARGS+= -DCMAKE_INSTALL_RPATH=${PREFIX}/lib
27-
CMAKE_CONFIGURE_ARGS+= -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=FALSE
22+
# \todo Remove or add a comment justifying.
23+
#CMAKE_CONFIGURE_ARGS+= -Wno-dev
2824

29-
CMAKE_ARG_PATH= ../
30-
CONFIGURE_DIRS= build
25+
# \todo Remove or add a comment justifying.
26+
#CMAKE_CONFIGURE_ARGS+= -DCMAKE_INSTALL_MANDIR=${PREFIX}/${PKGMANDIR}
27+
#CMAKE_CONFIGURE_ARGS+= -DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE
28+
#CMAKE_CONFIGURE_ARGS+= -DCMAKE_INSTALL_PREFIX=${PREFIX}
29+
#CMAKE_CONFIGURE_ARGS+= -DCMAKE_INSTALL_RPATH=${PREFIX}/lib
30+
#CMAKE_CONFIGURE_ARGS+= -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=FALSE
31+
32+
# \todo Remove or add a comment justifying.
33+
#CMAKE_ARG_PATH= ../
34+
#CONFIGURE_DIRS= build
3135

3236
PKG_SYSCONFSUBDIR= rtl_433
37+
# missing CONF_FILES?
3338

3439
PKGCONFIG_OVERRIDE+= rtl433.pc.in
3540

36-
pre-configure:
37-
${RUN} ${MKDIR} ${WRKSRC}/build
41+
# \todo Remove or add a comment justifying.
42+
#pre-configure:
43+
# ${RUN} ${MKDIR} ${WRKSRC}/build
3844

45+
# \todo Fix to install into examples/conf instead of removing, probably.
3946
pre-build:
4047
${RM} ${WRKSRC}/conf/CMakeLists.txt
4148

4249
post-install:
50+
# \todo File a bug upstream about needing to install the manpage.
4351
${INSTALL_MAN} ${WRKSRC}/man/man1/rtl_433.1 \
4452
${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
4553
${RM} -rf ${DESTDIR}${PREFIX}/share/man
4654
cd ${WRKSRC}/examples && ${PAX} -wr . ${DESTDIR}${PREFIX}/share/examples/rtl_433/
4755
cd ${WRKSRC}/conf && ${PAX} -wr . ${DESTDIR}${PREFIX}/share/examples/rtl_433/conf/
4856
cd ${WRKSRC}/docs && ${PAX} -wr . ${DESTDIR}${PREFIX}/share/doc/rtl_433/
57+
# \todo remove in source before copying, to be cleaner
4958
${RM} ${DESTDIR}${PREFIX}/share/doc/rtl_433/.gitignore
5059

5160
.include "options.mk"

0 commit comments

Comments
 (0)