Skip to content

Commit f39a791

Browse files
committed
Bugfix: Correctly size View in "Interstitial Diffusion"
1 parent 7a3b79c commit f39a791

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

Sample Models/Chemistry & Physics/Materials Science/Interstitial Diffusion.nlogox

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ end
271271
; Copyright 2025 Uri Wilensky.
272272
; See Info tab for full copyright and license.]]></code>
273273
<widgets>
274-
<view x="305" wrappingAllowedX="false" y="235" frameRate="30.0" minPycor="-200" height="2412" showTickCounter="true" patchSize="12.0" fontSize="10" wrappingAllowedY="true" width="492" tickCounterLabel="ticks" maxPycor="0" updateMode="1" maxPxcor="40" minPxcor="0"></view>
274+
<view x="305" wrappingAllowedX="false" y="235" frameRate="30.0" minPycor="-200" height="2416" showTickCounter="true" patchSize="12.0" fontSize="10" wrappingAllowedY="true" width="496" tickCounterLabel="ticks" maxPycor="0" updateMode="1" maxPxcor="40" minPxcor="0"></view>
275275
<slider x="10" step=".01" y="5" max="1" width="225" display="initial-bulk-concentration" height="50" min="0" direction="Horizontal" default="0.8" variable="initial-bulk-concentration"></slider>
276276
<slider x="10" step="1" y="60" max="world-width - 1" width="225" display="initial-columns-populated" height="50" min="0" direction="Horizontal" default="10.0" variable="initial-columns-populated"></slider>
277277
<button x="10" y="240" height="59" disableUntilTicks="true" forever="true" kind="Observer" width="107">go</button>

src/test/scala/org/nlogo/models/ViewTests.scala

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ class ViewTests extends TestModels {
3535
}
3636

3737

38-
val viewSizeIssueModels = Set("Interstitial Diffusion")
39-
// There really shouldn't be any exceeptions from this test though I must be honest, I don't actually
40-
// understand what this test does. They should be revisited in the future to actually
41-
// fix the underlying issue. -- CB 2025-12-17
4238
testModels("Saved view size must match size computed from the saved patch size and screen-edge-x/y") {
4339
// finds models whose graphics windows' saved sizes don't match the size you should get if you
4440
// compute from the saved patch size and screen-edge-x/y
@@ -48,9 +44,7 @@ class ViewTests extends TestModels {
4844
// happy seems to simply make sure that the view is at least 245 pixels wide.
4945
// Non-integer patch sizes can also cause problems, but those should be caught
5046
// by the previous test. -- NP 2015-05-25.
51-
Option(_)
52-
.filterNot(m => viewSizeIssueModels.contains(m.name))
53-
.filterNot(_.is3D).flatMap(checkModel)
47+
Option(_).filterNot(_.is3D).flatMap(checkModel)
5448
}
5549

5650
def checkModel(model: Model): Option[String] = {

0 commit comments

Comments
 (0)