Skip to content

Commit 1f01818

Browse files
committed
Simplify using statements
1 parent 90577aa commit 1f01818

File tree

4 files changed

+36
-50
lines changed

4 files changed

+36
-50
lines changed

src/Kavod.Vba.Compression/CompressedChunkData.cs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,13 @@ internal CompressedChunkData(BinaryReader dataReader, UInt16 compressedChunkData
2828
{
2929
var data = dataReader.ReadBytes(compressedChunkDataSize);
3030

31-
using (var reader = new BinaryReader(new MemoryStream(data)))
31+
using var reader = new BinaryReader(new MemoryStream(data));
32+
var position = 0;
33+
while (reader.BaseStream.Position < reader.BaseStream.Length)
3234
{
33-
var position = 0;
34-
while (reader.BaseStream.Position < reader.BaseStream.Length)
35-
{
36-
var sequence = TokenSequence.GetFromCompressedData(reader, position);
37-
_tokensequences.Add(sequence);
38-
position += (int)sequence.Tokens.Sum(t => t.Length);
39-
}
35+
var sequence = TokenSequence.GetFromCompressedData(reader, position);
36+
_tokensequences.Add(sequence);
37+
position += (int)sequence.Tokens.Sum(t => t.Length);
4038
}
4139
}
4240

src/Kavod.Vba.Compression/CompressedContainer.cs

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -47,21 +47,17 @@ internal CompressedContainer(DecompressedBuffer buffer)
4747

4848
internal byte[] SerializeData()
4949
{
50-
using (var writer = new BinaryWriter(new MemoryStream()))
51-
{
52-
writer.Write(SignatureByteSig);
53-
54-
foreach (var chunk in CompressedChunks)
55-
{
56-
writer.Write(chunk.SerializeData());
57-
}
50+
using var writer = new BinaryWriter(new MemoryStream());
51+
writer.Write(SignatureByteSig);
5852

59-
using (var reader = new BinaryReader(writer.BaseStream))
60-
{
61-
reader.BaseStream.Position = 0;
62-
return reader.ReadBytes((int) reader.BaseStream.Length);
63-
}
53+
foreach (var chunk in CompressedChunks)
54+
{
55+
writer.Write(chunk.SerializeData());
6456
}
57+
58+
using var reader = new BinaryReader(writer.BaseStream);
59+
reader.BaseStream.Position = 0;
60+
return reader.ReadBytes((int)reader.BaseStream.Length);
6561
}
6662
}
67-
}
63+
}

src/Kavod.Vba.Compression/DecompressedBuffer.cs

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,11 @@ internal class DecompressedBuffer
1212
{
1313
internal DecompressedBuffer(byte[] uncompressedData)
1414
{
15-
using (var reader = new BinaryReader(new MemoryStream(uncompressedData)))
15+
using var reader = new BinaryReader(new MemoryStream(uncompressedData));
16+
while (reader.BaseStream.Position < reader.BaseStream.Length)
1617
{
17-
while (reader.BaseStream.Position < reader.BaseStream.Length)
18-
{
19-
var chunk = new DecompressedChunk(reader);
20-
DecompressedChunks.Add(chunk);
21-
}
18+
var chunk = new DecompressedChunk(reader);
19+
DecompressedChunks.Add(chunk);
2220
}
2321
}
2422

@@ -36,20 +34,16 @@ internal byte[] Data
3634
{
3735
get
3836
{
39-
using (var writer = new BinaryWriter(new MemoryStream()))
37+
using var writer = new BinaryWriter(new MemoryStream());
38+
foreach (var chunk in DecompressedChunks)
4039
{
41-
foreach (var chunk in DecompressedChunks)
42-
{
43-
writer.Write(chunk.Data);
44-
}
40+
writer.Write(chunk.Data);
41+
}
4542

46-
using (var reader = new BinaryReader(writer.BaseStream))
47-
{
48-
reader.BaseStream.Position = 0;
43+
using var reader = new BinaryReader(writer.BaseStream);
44+
reader.BaseStream.Position = 0;
4945

50-
return reader.ReadBytes((int) reader.BaseStream.Length);
51-
}
52-
}
46+
return reader.ReadBytes((int)reader.BaseStream.Length);
5347
}
5448
}
5549
}

src/Kavod.Vba.Compression/DecompressedChunk.cs

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,18 @@ internal DecompressedChunk(CompressedChunk compressedChunk)
1616
if (compressedChunk.Header.IsCompressed)
1717
{
1818
// Loop through all the data, get TokenSequences and decompress them.
19-
using (var writer = new BinaryWriter(new MemoryStream()))
19+
using var writer = new BinaryWriter(new MemoryStream());
20+
var tokens = ((CompressedChunkData)compressedChunk.ChunkData).TokenSequences;
21+
foreach (var sequence in tokens)
2022
{
21-
var tokens = ((CompressedChunkData)compressedChunk.ChunkData).TokenSequences;
22-
foreach (var sequence in tokens)
23-
{
24-
sequence.Tokens.DecompressTokenSequence(writer);
25-
}
23+
sequence.Tokens.DecompressTokenSequence(writer);
24+
}
2625

27-
var stream = (MemoryStream)writer.BaseStream;
28-
var decompressedData = stream.GetBuffer();
29-
Array.Resize(ref decompressedData, (int)stream.Length);
26+
var stream = (MemoryStream)writer.BaseStream;
27+
var decompressedData = stream.GetBuffer();
28+
Array.Resize(ref decompressedData, (int)stream.Length);
3029

31-
Data = decompressedData;
32-
}
30+
Data = decompressedData;
3331
}
3432
else
3533
{

0 commit comments

Comments
 (0)